Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 6324009: dom-ui settings: save UI language state in local_state, not profile.... (Closed)

Created:
9 years, 11 months ago by csilv
Modified:
9 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews
Visibility:
Public.

Description

dom-ui settings: save UI language state in local_state, not profile. BUG=70351 TEST=Verify language change works on windows/linux. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/dom_ui/options/language_options_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
csilv
+jhawkins for review
9 years, 11 months ago (2011-01-21 23:41:38 UTC) #1
James Hawkins
LGTM. Is this how it works in the native code?
9 years, 11 months ago (2011-01-21 23:47:30 UTC) #2
csilv
9 years, 11 months ago (2011-01-21 23:51:39 UTC) #3
Yes it is.  I mistakenly missed that detail.

On 2011/01/21 23:47:30, James Hawkins wrote:
> LGTM. Is this how it works in the native code?

Powered by Google App Engine
This is Rietveld 408576698