Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 6324005: firmware-utiles: add *.attr for GPIO symbolic links (Closed)

Created:
9 years, 11 months ago by Hung-Te
Modified:
9 years, 7 months ago
Reviewers:
Randall Spangler
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

firmware-utiles: add *.attr for GPIO symbolic links To recognize the polarity of each GPIO, we need to expose the information from chromeos_acpi interface. BUG=chrome-os-partner:1940 TEST=(on mario, BIOS ver = G5) gpio_setup; cd /home/gpio; ls -l # complete output: (output_header[1-7] is stripped) # debug_header_0 -> /sys/class/gpio/gpio201/value # debug_header_0.attr -> /sys/bus/platform/devices/chromeos_acpi/GPIO.3/GPIO.1 # developer_switch -> /sys/class/gpio/gpio193/value # developer_switch.attr -> /sys/bus/platform/devices/chromeos_acpi/GPIO.1/GPIO.1 # recovery_button -> /sys/class/gpio/gpio230/value # recovery_button.attr -> /sys/bus/platform/devices/chromeos_acpi/GPIO.0/GPIO.1 # write_protect -> /sys/class/gpio/gpio226/value # write_protect.attr -> /sys/bus/platform/devices/chromeos_acpi/GPIO.2/GPIO.1 for X in *.attr; do echo $X - $(cat $X); done # debug_header_0.attr - 0 # developer_switch.attr - 1 # recovery_button.attr - 0 # write_protect.attr - 0 (this should be 1 in new BIOS) Change-Id: Ib42b4662c4369112a8f4fb69989d62f2d1b76590 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=beb9877

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -25 lines) Patch
M gpio_setup.cc View 6 chunks +50 lines, -25 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Hung-Te
9 years, 11 months ago (2011-01-17 09:30:34 UTC) #1
Hung-Te
Any updates? We will need this in order to allow Alex factory tests to work.
9 years, 11 months ago (2011-01-19 03:00:18 UTC) #2
Randall Spangler
9 years, 11 months ago (2011-01-20 00:52:55 UTC) #3
LGTM, thanks

Powered by Google App Engine
This is Rietveld 408576698