Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 6323014: Disable the URLRequestTestHTTP.DefaultUserAgent for ChromeFrame net tests as ... (Closed)

Created:
9 years, 11 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, amit
Visibility:
Public.

Description

Disable the URLRequestTestHTTP.DefaultUserAgent for ChromeFrame net tests as this test expects an empty UA to be echoed back which won't be the case in ChromeFrame. BUG=none TEST=none TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72196

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome_frame/test/net/fake_external_tab.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
9 years, 11 months ago (2011-01-21 21:37:56 UTC) #1
amit
9 years, 11 months ago (2011-01-22 02:29:21 UTC) #2
Ok
 On Jan 21, 2011 1:38 PM, <ananta@chromium.org> wrote:
> Reviewers: amit,
>
> Description:
> Disable the URLRequestTestHTTP.DefaultUserAgent for ChromeFrame net tests
as
> this test
> expects an empty UA to be echoed back which won't be the case in
> ChromeFrame.
>
> BUG=none
> TEST=none
> TBR=amit
>
>
> Please review this at http://codereview.chromium.org/6323014/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
> M chrome_frame/test/net/fake_external_tab.cc
>
>
> Index: chrome_frame/test/net/fake_external_tab.cc
> ===================================================================
> --- chrome_frame/test/net/fake_external_tab.cc (revision 72150)
> +++ chrome_frame/test/net/fake_external_tab.cc (working copy)
> @@ -457,6 +457,10 @@
> // Chrome's HTTP stack like the ability to set the proxy for a URL,
> etc.
> "URLRequestTestHTTP.ProxyTunnelRedirectTest",
> "URLRequestTestHTTP.UnexpectedServerAuthTest",
> +
> + // This test is disabled as it expects an empty UA to be echoed back
> from
> + // the server which is not the case in ChromeFrame.
> + "URLRequestTestHTTP.DefaultUserAgent",
> };
>
> std::string filter("-"); // All following filters will be negative.
>
>

Powered by Google App Engine
This is Rietveld 408576698