Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 6323001: We forgot to call Associate in case of local changes. (Closed)

Created:
9 years, 11 months ago by lipalani1
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, Paweł Hajdan Jr., Ilya Sherman, James Hawkins, tim (not reviewing), dhollowa
Visibility:
Public.

Description

We forgot to call Associate in case of local changes for autofill. When a local profile is created we create the corresponding sync node and we need to associate the sync node with profile. We forgot to make the call and that is fixed in this cl. BUG=68912, 69173 TEST= sync_integration_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71409

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/sync/glue/autofill_profile_change_processor.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/live_sync/two_client_live_autofill_sync_test.cc View 2 chunks +2 lines, -2 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
lipalani1
We forgot to put in a call to Associate(guid, id) when an item was created ...
9 years, 11 months ago (2011-01-13 20:27:21 UTC) #1
lipalani1
9 years, 11 months ago (2011-01-13 21:53:06 UTC) #2
Raghu Simha
Drive-by code review; no need to wait for an LGTM from me. I suggest you ...
9 years, 11 months ago (2011-01-13 22:16:10 UTC) #3
tim (not reviewing)
9 years, 11 months ago (2011-01-14 01:00:11 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698