Issue 6321025: Further modifications to the Ready Mode UI in response to feedback. Height, i...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6321025: Further modifications to the Ready Mode UI in response to feedback. Height, i... (Closed)

Created:
9 years, 11 months ago by erikwright (departed)

Modified:
9 years, 7 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Further modifications to the Ready Mode UI in response to feedback. Height, icon dimensions, text positioning are same as IE infobars. Buttons now implement user selected theme. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78311

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -7 lines)			Patch
M	chrome/app/cf_resources.rc	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	chrome_frame/chrome_frame.gyp	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome_frame/ready_mode/internal/ready_prompt_window.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome_frame/ready_mode/internal/ready_prompt_window.cc	View		2 chunks	+13 lines, -0 lines	0 comments	Download
A	chrome_frame/resources/npchrome_frame.dll.manifest	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm.  looks great.

Expand Messages | Collapse Messages