Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 6321014: Save/Restore ALSA volume/mute fix (Closed)

Created:
9 years, 11 months ago by davejcool
Modified:
9 years, 7 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org
Visibility:
Public.

Description

Save/Restore ALSA volume/mute fix After getting volume and mute to restore (Issue 6118006), there was one case where it did not: if volume was adjusted for the first time after a fresh install, it would not be remembered on next boot until mute was pressed at least once. BUG=chromium-os:10470 TEST=Manual, volume should be the same after adjusting after fresh install and rebooting Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72179

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/chromeos/audio_mixer_alsa.cc View 1 chunk +1 line, -1 line 3 comments Download

Messages

Total messages: 4 (0 generated)
davejcool
A very small update to the last Save/Restore ALSA volume settings patch. http://codereview.chromium.org/6321014/diff/1/chrome/browser/chromeos/audio_mixer_alsa.cc File chrome/browser/chromeos/audio_mixer_alsa.cc ...
9 years, 11 months ago (2011-01-21 19:29:15 UTC) #1
zhurunz
LGTM.
9 years, 11 months ago (2011-01-21 19:41:28 UTC) #2
scherkus (not reviewing)
LGTM w/ nit http://codereview.chromium.org/6321014/diff/1/chrome/browser/chromeos/audio_mixer_alsa.cc File chrome/browser/chromeos/audio_mixer_alsa.cc (right): http://codereview.chromium.org/6321014/diff/1/chrome/browser/chromeos/audio_mixer_alsa.cc#newcode304 chrome/browser/chromeos/audio_mixer_alsa.cc:304: DoSetVolumeDb_Locked(pref_volume); nit: indentation is off here
9 years, 11 months ago (2011-01-21 21:26:04 UTC) #3
davejcool
9 years, 11 months ago (2011-01-21 22:39:29 UTC) #4
http://codereview.chromium.org/6321014/diff/1/chrome/browser/chromeos/audio_m...
File chrome/browser/chromeos/audio_mixer_alsa.cc (right):

http://codereview.chromium.org/6321014/diff/1/chrome/browser/chromeos/audio_m...
chrome/browser/chromeos/audio_mixer_alsa.cc:304:
DoSetVolumeDb_Locked(pref_volume);
On 2011/01/21 21:26:04, scherkus wrote:
> nit: indentation is off here

D'oh!  This'll be formatted right in the next CL...

Powered by Google App Engine
This is Rietveld 408576698