Fix ChromeFrame perf redness caused by the change to move the creation of the...

Fix ChromeFrame perf redness caused by the change to move the creation of the proxy launcher
to UITest::Setup. ChromeFrame perf tests override the Setup method and don't invoke the Base
UITest::Setup implementation. 

This causes a crash in UITest::TearDown invoked during the ChromeFrame perf test runs where 
we crash as the launcher is NULL. Added a check for the same.

BUG=none
TEST=chrome frame perf tests.
TBR=amit


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71733

[amit, 2011-01-19 00:26:25]

ok

On Tue, Jan 18, 2011 at 4:22 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Fix ChromeFrame perf redness caused by the change to move the creation of
> the
> proxy launcher
> to UITest::Setup. ChromeFrame perf tests override the Setup method and
> don't
> invoke the Base
> UITest::Setup implementation.
>
> This causes a crash in UITest::TearDown invoked during the ChromeFrame perf
> test
> runs where
> we crash as the launcher is NULL. Added a check for the same.
>
> BUG=none
> TEST=chrome frame perf tests.
> TBR=amit
>
>
> Please review this at http://codereview.chromium.org/6321010/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/test/ui/ui_test.cc
>
>
> Index: chrome/test/ui/ui_test.cc
> ===================================================================
> --- chrome/test/ui/ui_test.cc   (revision 71693)
> +++ chrome/test/ui/ui_test.cc   (working copy)
> @@ -196,7 +196,8 @@
>  }
>
>  void UITestBase::CloseBrowserAndServer() {
> -  launcher_->CloseBrowserAndServer(shutdown_type_);
> +  if (launcher_.get())
> +    launcher_->CloseBrowserAndServer(shutdown_type_);
>  }
>
>  void UITestBase::LaunchBrowser(const CommandLine& arguments,
>
>
>