Issue 6321004: Disables MultiProcessNotificationTests....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6321004: Disables MultiProcessNotificationTests.... (Closed)

Created:
9 years, 11 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, dmac, Timur Iskhodzhanov

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disables MultiProcessNotificationTests. This change just disables MultiProcessNotificationTests added by r71418 <http://crrev.com/71418>; because they always crash on the "Chromium Mac (valgrind)" bot. (We also disable other MultiProcessNotificationTests?) TBR=dmaclach,thestig,timurrrr BUG=69641 TEST=make the "Chromium Mac (valgrind)" bot green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71423

Patch Set 1 #

Created: 9 years, 11 months ago

		Unified diffs	Side-by-side diffs	Stats (+5 lines, -0 lines)
	M	tools/valgrind/gtest_exclude/unit_tests.gtest_mac.txt	View	1 chunk	+5 lines, -0 lines	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

9 years, 11 months ago (2011-01-14 10:00:24 UTC) #2

LGTM (timurrrr is on a vacation)


On Fri, Jan 14, 2011 at 12:24 PM,  <hbono@chromium.org> wrote:
> Reviewers: dmac, Lei Zhang, Timur Iskhodzhanov,
>
> Description:
> Disables MultiProcessNotificationTests.
> This change just disables MultiProcessNotificationTests added by r71418
> <http://crrev.com/71418> because they always crash on the "Chromium Mac
> (valgrind)" bot. (We also disable other MultiProcessNotificationTests?)
>
> TBR=dmaclach,thestig,timurrrr
> BUG=69641
> TEST=make the "Chromium Mac (valgrind)" bot green.
>
> Please review this at http://codereview.chromium.org/6321004/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/gtest_exclude/unit_tests.gtest_mac.txt
>
>
> Index: tools/valgrind/gtest_exclude/unit_tests.gtest_mac.txt
> ===================================================================
> --- tools/valgrind/gtest_exclude/unit_tests.gtest_mac.txt       (revision
> 71405)
> +++ tools/valgrind/gtest_exclude/unit_tests.gtest_mac.txt       (working
> copy)
> @@ -19,3 +19,8 @@
>  PrefsControllerTest.GetToolbarItemForPage
>  PrefsControllerTest.ShowAndClose
>  PrefsControllerTest.SwitchToPage
> +
> +# MultiProcessNotificationTests crash on the valgrind bot.
> +# See http://crbug.com/69641.
> +MultiProcessNotificationTest.BasicCreationTest
> +MultiProcessNotificationTest.PostInProcessNotification
>
>
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow

Expand Messages | Collapse Messages