Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: chrome/browser/resources/options/options_page.css

Issue 6320015: DOMUI Prefs: Improve focus appearance on Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/options_page.css
diff --git a/chrome/browser/resources/options/options_page.css b/chrome/browser/resources/options/options_page.css
index 4fd4a86bb0e6b73ae7ffd665aff9893b21b0d177..11af7bdb31dfa07686c8e270c101ebe87546f1e4 100644
--- a/chrome/browser/resources/options/options_page.css
+++ b/chrome/browser/resources/options/options_page.css
@@ -559,12 +559,20 @@ html[enable-cloud-print-proxy=true] #cloudPrintProxyManageButton {
/* UI Controls */
-button:focus,
-input:focus,
-input[type='submit']:focus,
-select:focus {
+/* Currently we can't make custom focus outlines look right on the Mac, so
+ * we stick to native focus rings. Once outlines follow border radius, we
+ * can revisit.
+ */
+html:not([os=mac]) button:focus,
+html:not([os=mac]) input:focus,
+html:not([os=mac]) input[type='submit']:focus,
+html:not([os=mac]) select:focus {
outline-color: rgba(0, 128, 256, 0.5);
}
+html[os=mac] button:focus,
+html[os=mac] input[type='submit']:focus {
+ outline-offset: -2px;
+}
/* TEXT */
input[type='password'],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698