Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: metrics_library.h

Issue 6320009: metrics: Update comment about adding user actions. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/metrics.git@master
Patch Set: update comment Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: metrics_library.h
diff --git a/metrics_library.h b/metrics_library.h
index 4bbd0d3a18b28287b4294f6c8cf1e07e54c95a6a..ed8386202b9280ca097179483900754a22d3e41d 100644
--- a/metrics_library.h
+++ b/metrics_library.h
@@ -72,9 +72,12 @@ class MetricsLibrary : public MetricsLibraryInterface {
// Sends a user action to Chrome for transport to UMA and returns true on
// success. This method results in the equivalent of an asynchronous
- // non-blocking RPC to UserMetrics::RecordAction (see the comments in
- // chrome/browser/chromeos/external_metrics.cc and
- // chrome/browser/metrics/user_metrics.h on how to register new user actions).
+ // non-blocking RPC to UserMetrics::RecordAction. The new metric must be
+ // added to chrome/tools/extract_actions.py in the Chromium repository, which
+ // should then be run to generate a hash for the new action.
+ //
+ // Until http://crosbug.com/11125 is fixed, the metric must also be added to
+ // chrome/browser/chromeos/external_metrics.cc.
//
// |action| is the user-generated event (e.g., "MuteKeyPressed").
bool SendUserActionToUMA(const std::string& action);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698