Issue 6320004: Add some OWNERS files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6320004: Add some OWNERS files. (Closed)

Created:
9 years, 11 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add some OWNERS files. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71484

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -0 lines)			Patch
A	ui/OWNERS	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	ui/base/OWNERS	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	views/OWNERS	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	views/focus/OWNERS	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

About views/focus: I know Jay is working on other things but he is still the ...

9 years, 11 months ago (2011-01-14 20:35:10 UTC) #1

darin (slow to review)

9 years, 11 months ago (2011-01-14 20:51:15 UTC) #2

LGTM

On Fri, Jan 14, 2011 at 12:35 PM, <ben@chromium.org> wrote:

> Reviewers: darin,
>
> Message:
> About views/focus: I know Jay is working on other things but he is still
> the
> best person to review this code, and it doesn't change that much. I am
> going to
> try and ramp up some other folk in this area though.
>
> Description:
> Add some OWNERS files.
>
> BUG=none
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/6320004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  A     ui/OWNERS
>  A     ui/base/OWNERS
>  A     views/OWNERS
>  A     views/focus/OWNERS
>
>
> Index: ui/OWNERS
> ===================================================================
> --- ui/OWNERS   (revision 0)
> +++ ui/OWNERS   (revision 0)
> @@ -0,0 +1,2 @@
> +ben@chromium.org
> +sky@chromium.org
> Index: ui/base/OWNERS
> ===================================================================
> --- ui/base/OWNERS      (revision 0)
> +++ ui/base/OWNERS      (revision 0)
> @@ -0,0 +1,2 @@
> +ben@chromium.org
> +sky@chromium.org
> Index: views/OWNERS
> ===================================================================
> --- views/OWNERS        (revision 0)
> +++ views/OWNERS        (revision 0)
> @@ -0,0 +1,2 @@
> +ben@chromium.org
> +sky@chromium.org
> Index: views/focus/OWNERS
> ===================================================================
> --- views/focus/OWNERS  (revision 0)
> +++ views/focus/OWNERS  (revision 0)
> @@ -0,0 +1 @@
> +jcivelli@chromium.org
>
>
>

Expand Messages | Collapse Messages