Issue 6320002: O2D: Several (unrelated) improvements:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6320002: O2D: Several (unrelated) improvements:... (Closed)

Created:
9 years, 11 months ago by Tristan Schmelcher 2

Modified:
9 years, 6 months ago

Reviewers:
geer, zhurunz, Tim H

CC:
o3d-review_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/o3d/

Visibility:
Public.

Description

O2D: Several (unrelated) improvements: - Use Cairo double-buffering (prevents flickering when there is translucency). - Add an API to allow JS to indicate the stacking order of layers. (Previously it was the arbitrary order of their creation!) - Delete layer objects that have been discarded by the JS via Pack::RemoveObject(). TEST=loaded O2D and verified no significant change in perf as a result of double-buffering (~70% of a core before and ~72% of a core after) BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71475

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -19 lines)			Patch
M	core/cross/cairo/layer.h	View	3 chunks	+13 lines, -0 lines	0 comments	Download
M	core/cross/cairo/layer.cc	View	2 chunks	+12 lines, -5 lines	0 comments	Download
M	core/cross/cairo/renderer_cairo.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	core/cross/cairo/renderer_cairo.cc	View	6 chunks	+31 lines, -11 lines	0 comments	Download
M	plugin/idl/layer.idl	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages