Issue 6320001: Tag a couple of functions with OVERRIDE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6320001: Tag a couple of functions with OVERRIDE (Closed)

Created:
9 years, 11 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, evanm

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Tag a couple of functions with OVERRIDE I'm going to be updating the underlying class (in WebKit) and don't want these functions to be siliently disconnected in the event that the WebKit merge doesn't work exactly as planned. BUG=none TEST=compile

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	chrome/renderer/render_view.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
	M	webkit/tools/test_shell/test_webview_delegate.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages