Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3269)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 6319001: Support window.opener after a process swap. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add WasSwappedOut message for clean exit. Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index e3d03c5b92ead0a2f1d3b763373e9acd5dda90b8..20c72eb1b200d1698918dc75b5a63980fe0a7efa 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -445,9 +445,6 @@ bool ChromeContentRendererClient::ShouldFork(WebFrame* frame,
// TODO(erikkay) This is happening inside of a check to is_content_initiated
// which means that things like the back button won't trigger it. Is that
// OK?
- // TODO(creis): For hosted apps, we currently only swap processes to enter
- // the app and not exit it, since we currently lose context (e.g.,
- // window.opener) if the window navigates back. See crbug.com/65953.
if (!CrossesExtensionExtents(frame, url))
return false;
@@ -543,10 +540,7 @@ bool ChromeContentRendererClient::CrossesExtensionExtents(WebFrame* frame,
if (old_url.is_empty() && frame->opener())
old_url = frame->opener()->url();
- bool old_url_is_hosted_app = extensions->GetByURL(old_url) &&
- !extensions->GetByURL(old_url)->web_extent().is_empty();
- return !extensions->InSameExtent(old_url, new_url) &&
- !old_url_is_hosted_app;
+ return !extensions->InSameExtent(old_url, new_url);
}
} // namespace chrome

Powered by Google App Engine
This is Rietveld 408576698