Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: chrome/browser/ui/browser.h

Issue 6318001: Revert 71327 - Attempt at fixing crash in ProcessPendingTabs. With the curren... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.h
===================================================================
--- chrome/browser/ui/browser.h (revision 71335)
+++ chrome/browser/ui/browser.h (working copy)
@@ -909,13 +909,8 @@
// Cleans up state appropriately when we are trying to close the browser and
// the tab has finished firing its unload handler. We also use this in the
// cases where a tab crashes or hangs even if the beforeunload/unload haven't
- // successfully fired. If |process_now| is true |ProcessPendingTabs| is
- // invoked immediately, otherwise it is invoked after a delay (PostTask).
- //
- // Typically you'll want to pass in true for |process_now|. Passing in true
- // may result in deleting |tab|. If you know that shouldn't happen (because of
- // the state of the stack), pass in false.
- void ClearUnloadState(TabContents* tab, bool process_now);
+ // successfully fired.
+ void ClearUnloadState(TabContents* tab);
// In-progress download termination handling /////////////////////////////////
« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698