Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 6318001: Revert 71327 - Attempt at fixing crash in ProcessPendingTabs. With the curren... (Closed)

Created:
9 years, 11 months ago by sky
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 71327 - Attempt at fixing crash in ProcessPendingTabs. With the current code, during closing a window with unload handlers if a tab is disconnected then we delay cleanup by way of PostTask with the tab being disconnected. During the time between when the disconnect happens and the task is run the unloader handler sets still maintain a reference to the tab. If ProcessPendingTabs is invoked during this window and the tab is deleted, then we can crash. I'm fixing it by making disconnect remove from the sets immediately, but delay the call to ProcessPendingTabs. I'm also doing a similar thing in TabDetachedAt. BUG=15620 TEST=none Review URL: http://codereview.chromium.org/6203006 TBR=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71336

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -30 lines) Patch
M chrome/browser/ui/browser.h View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser.cc View 6 chunks +12 lines, -23 lines 0 comments Download
M chrome/test/data/reliability/known_crashes.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sky
9 years, 11 months ago (2011-01-13 18:45:42 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698