Change UTF8ToUTF16 to accept const StringPiece&.

base/logging.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_LOGGING_H_
 #define BASE_LOGGING_H_
 #pragma once
 
 #include <string>
 #include <cstring>
@@ skipping 901 matching lines @@
 #define NOTIMPLEMENTED() NOTREACHED()
 #elif NOTIMPLEMENTED_POLICY == 4
 #define NOTIMPLEMENTED() LOG(ERROR) << NOTIMPLEMENTED_MSG
 #elif NOTIMPLEMENTED_POLICY == 5
 #define NOTIMPLEMENTED() do {\
   static int count = 0;\
   LOG_IF(ERROR, 0 == count++) << NOTIMPLEMENTED_MSG;\
 } while(0)
 #endif
 
+namespace base {
+
+class StringPiece;
+
+// allow StringPiece to be logged (needed for unit testing).
+extern std::ostream& operator<<(std::ostream& o, const StringPiece& piece);

[brettw, 2011/01/27 04:10:42]

What's the advantage of moving this? We were just discussing wanting to remove
the wstring operator<< from logging.h.

[James Su, 2011/01/27 04:19:57]

By moving this piece of code here, we can remove #include <iosfwd> from
string_piece.h.
This change shouldn't affect normal code at all, as stream should only be used
for logging.

[brettw, 2011/01/27 04:26:14]

I'm on the fence. I don't really like adding this stuff to logging.h, but
avoiding the extra include can be nice. I'd actually prefer to remove this
altogether if it's not an unreasonable amount of work.

What do other reviewers think?

[James Su, 2011/01/27 04:42:04]

Do you mean we should avoid using it even for logging? I'll try to remove it and
see how many files will be affected.

+
+}  // namespace base
+
 #endif  // BASE_LOGGING_H_