Add buildbot functionality to cbuildbot.

Add buildbot functionality to cbuildbot.

Change-Id: I1291d2f52122fe345c5927a7ef27e20d07e917d7

BUG=chromium-os:11229
TEST=(building locally, still in progress)

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=91c3937

[sosa, 2011-01-25 22:12:31]

Did you mean to put me as a reviewer?

On Tue, Jan 25, 2011 at 2:10 PM,  <dgarrett@chromium.org> wrote:
> Reviewers: ,
>
> Description:
> Add buildbot functionality to cbuildbot.
>
> Change-Id: I1291d2f52122fe345c5927a7ef27e20d07e917d7
>
> BUG=chromium-os:11229
> TEST=(building locally, still in progress)
>
> Please review this at http://codereview.chromium.org/6317014/
>
> SVN Base: http://git.chromium.org/git/crosutils.git@master
>
> Affected files:
>  M bin/cbuildbot.py
>  M bin/cbuildbot_config.py
>
>
>

[dgarrett, 2011-01-25 22:16:06]

Of course. I'm not sure why I still fight with the review system so much.

On Tue, Jan 25, 2011 at 2:12 PM, Chris Sosa <sosa@chromium.org> wrote:

> Did you mean to put me as a reviewer?
>
> On Tue, Jan 25, 2011 at 2:10 PM,  <dgarrett@chromium.org> wrote:
> > Reviewers: ,
> >
> > Description:
> > Add buildbot functionality to cbuildbot.
> >
> > Change-Id: I1291d2f52122fe345c5927a7ef27e20d07e917d7
> >
> > BUG=chromium-os:11229
> > TEST=(building locally, still in progress)
> >
> > Please review this at http://codereview.chromium.org/6317014/
> >
> > SVN Base: http://git.chromium.org/git/crosutils.git@master
> >
> > Affected files:
> >  M bin/cbuildbot.py
> >  M bin/cbuildbot_config.py
> >
> >
> >
>



-- 
Don

[sosa, 2011-01-25 22:54:48]

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py
File bin/cbuildbot.py (right):

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode332
bin/cbuildbot.py:332: def _CachePackages(buildroot, board, package_cache,
restore):
As per discussion, let's remove this.

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode531
bin/cbuildbot.py:531: def _ArchiveBuild(bot_id, buildconfig, buildnumber):
Can you rename to _OldArchiveBuild or LegacyArchiveBuild.  We're moving away
from that script per say so let's call this something

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode538
bin/cbuildbot.py:538: # TODO: Currently, --to is based on a known config for the
buildbot
Remove this TODO.  It is obselete (we use gsutil from this to dir to archive
things)

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode558
bin/cbuildbot.py:558: if buildconfig.get('test_mod', True):
isn't this equivalent to buildconfig.get('testmod')?

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode559
bin/cbuildbot.py:559: cmd += ['--test_mod']
append rather than +=

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode562
bin/cbuildbot.py:562: cmd += ['--factory_install_mod']
append rather than +=

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode565
bin/cbuildbot.py:565: cmd += ['--factory_test_mod']
append rather than +=

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode568
bin/cbuildbot.py:568: #RunCommand(cmd)
if not debug rather than comment out

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode714
bin/cbuildbot.py:714: help="Don't actually build (for cbuildbot devel")
dev*

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode724
bin/cbuildbot.py:724: parser.add_option('--package-cache', dest='package_cache',
As per our discussions with scottz / raja ... let's remove this option.

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode785
bin/cbuildbot.py:785: _CachePackages(buildroot, board,
Remove

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode809
bin/cbuildbot.py:809: if options.package_cache:
Remove

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode817
bin/cbuildbot.py:817: if options.build:
Merge into other build cmd

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot_config.py
File bin/cbuildbot_config.py (right):

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot_config.py#newcode43
bin/cbuildbot_config.py:43: 'push_overlays': None,
Set the new values to false in the default?

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot_config.py#newcode126
bin/cbuildbot_config.py:126: }
Can you add the full configs?

[dgarrett, 2011-01-25 23:38:51]

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py
File bin/cbuildbot.py (right):

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode332
bin/cbuildbot.py:332: def _CachePackages(buildroot, board, package_cache,
restore):
On 2011/01/25 22:54:48, sosa wrote:
> As per discussion, let's remove this.

Done.

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode531
bin/cbuildbot.py:531: def _ArchiveBuild(bot_id, buildconfig, buildnumber):
On 2011/01/25 22:54:48, sosa wrote:
> Can you rename to _OldArchiveBuild or LegacyArchiveBuild.  We're moving away
> from that script per say so let's call this something 

Done.

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode558
bin/cbuildbot.py:558: if buildconfig.get('test_mod', True):
On 2011/01/25 22:54:48, sosa wrote:
> isn't this equivalent to buildconfig.get('testmod')?

No. This gives it a default value, so that it doesn't have to explicitly be
defined for every config.

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode559
bin/cbuildbot.py:559: cmd += ['--test_mod']
On 2011/01/25 22:54:48, sosa wrote:
> append rather than +=

Done.

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode562
bin/cbuildbot.py:562: cmd += ['--factory_install_mod']
On 2011/01/25 22:54:48, sosa wrote:
> append rather than +=

Done.

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode565
bin/cbuildbot.py:565: cmd += ['--factory_test_mod']
On 2011/01/25 22:54:48, sosa wrote:
> append rather than +=

Done.

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode568
bin/cbuildbot.py:568: #RunCommand(cmd)
On 2011/01/25 22:54:48, sosa wrote:
> if not debug rather than comment out

Makes sense.

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode714
bin/cbuildbot.py:714: help="Don't actually build (for cbuildbot devel")
On 2011/01/25 22:54:48, sosa wrote:
> dev*

Done.

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode724
bin/cbuildbot.py:724: parser.add_option('--package-cache', dest='package_cache',
On 2011/01/25 22:54:48, sosa wrote:
> As per our discussions with scottz / raja ... let's remove this option.

Done.

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode785
bin/cbuildbot.py:785: _CachePackages(buildroot, board,
On 2011/01/25 22:54:48, sosa wrote:
> Remove

Done.

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode809
bin/cbuildbot.py:809: if options.package_cache:
On 2011/01/25 22:54:48, sosa wrote:
> Remove

Done.

http://codereview.chromium.org/6317014/diff/1/bin/cbuildbot.py#newcode817
bin/cbuildbot.py:817: if options.build:
On 2011/01/25 22:54:48, sosa wrote:
> Merge into other build cmd

Done.

[sosa, 2011-01-26 00:40:04]

LGTM w/ nit.

http://codereview.chromium.org/6317014/diff/10001/bin/cbuildbot.py
File bin/cbuildbot.py (right):

http://codereview.chromium.org/6317014/diff/10001/bin/cbuildbot.py#newcode488
bin/cbuildbot.py:488: def _LegacyArchiveBuild(bot_id, buildconfig, buildnumber,
debug = False):
no spaces in keyval args in params