Make CommandBuffer::Flush asynchronous, and add CommandBuffer::FlushSync with former semantics.

gpu/pgl/command_buffer_pepper.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/pgl/command_buffer_pepper.h"
 
 #include "gpu/command_buffer/common/logging.h"
 
 using base::SharedMemory;
 using gpu::Buffer;
@@ skipping 65 matching lines @@
 
   if (NPERR_NO_ERROR != device_->flushContext(npp_, context_, NULL, NULL))
     context_->error = NPDeviceContext3DError_GenericError;
 
   context_->waitForProgress = true;
 
   return ConvertState();
 #endif  // ENABLE_NEW_NPDEVICE_API
 }
 
-CommandBuffer::State CommandBufferPepper::Flush(int32 put_offset) {
+void CommandBufferPepper::Flush(int32 put_offset) {

[apatrick, 2011/01/14 18:31:34]

I think we might want to change PPAPI to make the distinction between sync and
async flushes.

[Antoine Labour, 2011/01/14 21:35:33]

This is old Pepper v1 code. It will go away in a few days, I'm just keeping it
compiling and working semantically.

For PPAPI (Pepper v2) code, the command buffers aren't exposed directly to the
client. All the client has is higher level glFlush, glFinish and other blocking
calls - and possibly fences if we add them. I don't think there's a point in
exposing the "sync" flush as such to the client, but it is currently necessary
for the underlying implementation to avoid busy-waiting (though I want to
replace it with Wait interfaces - e.g. wait-on-get-reaching-that-value or
wait-on-token-reaching-that-value - that would reduce IPC traffic and improve
latency a little bit).

+  FlushSync(put_offset);
+}
+
+CommandBuffer::State CommandBufferPepper::FlushSync(int32 put_offset) {
 #if defined(ENABLE_NEW_NPDEVICE_API)
   int32 input_attribs[] = {
     NP3DAttrib_PutOffset, put_offset,
     NPAttrib_End
   };
   int32 output_attribs[] = {
     NP3DAttrib_CommandBufferSize, 0,
     NP3DAttrib_GetOffset, 0,
     NP3DAttrib_PutOffset, 0,
     NP3DAttrib_Token, 0,
@@ skipping 85 matching lines @@
 CommandBuffer::State CommandBufferPepper::ConvertState() {
   CommandBuffer::State state;
   state.num_entries = context_->commandBufferSize;
   state.get_offset = context_->getOffset;
   state.put_offset = context_->putOffset;
   state.token = context_->token;
   state.error = static_cast<gpu::error::Error>(
       context_->error);
   return state;
 }