Use a random number to generate a self-signed certiciate for chromoting

remoting/protocol/jingle_session_manager.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <limits>
+
 #include "remoting/protocol/jingle_session_manager.h"

[wtc, 2011/01/20 01:33:05]

Nit: the Style Guide recommends that this header be listed
first, before C and C++ system headers.  So <limits> should
be listed after this line.

 
 #include "base/base64.h"
 #include "base/message_loop.h"
+#include "base/rand_util.h"
 #include "base/string_number_conversions.h"
 #include "remoting/base/constants.h"
 #include "remoting/jingle_glue/jingle_thread.h"
 #include "remoting/proto/auth.pb.h"
 #include "third_party/libjingle/source/talk/p2p/base/constants.h"
 #include "third_party/libjingle/source/talk/p2p/base/transport.h"
 #include "third_party/libjingle/source/talk/xmllite/xmlelement.h"
 
 using buzz::QName;
 using buzz::XmlElement;
@@ skipping 256 matching lines @@
   // Allow local connections if neccessary.
   cricket_session->set_allow_local_ips(allow_local_ips_);
 
   // If this is an outcoming session the session object is already created.
   if (incoming) {
     // Generate private key and certificate.
     // TODO(hclam): Instead of generating we should restore them from the disk.
     if (!certificate_) {
       private_key_.reset(base::RSAPrivateKey::Create(1024));
       certificate_ = net::X509Certificate::CreateSelfSigned(
-          private_key_.get(), "CN=chromoting", 1,
+          private_key_.get(), "CN=chromoting",
+          base::RandInt(1, std::numeric_limits<int>::max()),

[wtc, 2011/01/20 01:33:05]

This is correct.  But it uses only half of the possible
range (because 'int' is signed).

Alternatively, since the serial_number parameter is uint32,
you can also call base::RandUint64() and truncate the return
value to uint32.

           base::TimeDelta::FromDays(1));
       CHECK(certificate_);
     }
     JingleSession* jingle_session =
         JingleSession::CreateServerSession(this, certificate_,
                                            private_key_.release());
     certificate_ = NULL;
     sessions_.push_back(make_scoped_refptr(jingle_session));
     jingle_session->Init(cricket_session);
   }
@@ skipping 249 matching lines @@
     scoped_refptr<net::X509Certificate> certificate) {
   cricket::SessionDescription* desc = new cricket::SessionDescription();
   desc->AddContent(JingleSession::kChromotingContentName,
                    kChromotingXmlNamespace,
                    new ContentDescription(config, auth_token, certificate));
   return desc;
 }
 
 }  // namespace protocol
 }  // namespace remoting