Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Unified Diff: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

Issue 6315005: This is the Chromium side of my WebKit change that fixes some Find issues wit... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
===================================================================
--- chrome/browser/ui/find_bar/find_bar_host_browsertest.cc (revision 71302)
+++ chrome/browser/ui/find_bar/find_bar_host_browsertest.cc (working copy)
@@ -438,11 +438,15 @@
int ordinal = 0;
TabContents* tab = browser()->GetSelectedTabContents();
- // The search string is present but doesn't qualify to be found
- EXPECT_EQ(0, FindInPageWchar(tab, L"text",
- kFwd, kIgnoreCase, &ordinal));
- // With zero results there should be no current selection.
- EXPECT_EQ(0, ordinal);
+
+ int match_count =
+ FindInPageWchar(tab, L"text", kFwd, kIgnoreCase, &ordinal);
+ // TODO(finnur): These two values are currently 0 and 0 but will change to
+ // 1 and 1 when we merge down a fix for un-selectable text in patch from
+ // revision 75784 (https://bugs.webkit.org/show_bug.cgi?id=52367). Once the
+ // patch has been rolled into Chromium I'll change this back to check for 1
+ // explicitly (as opposed to using equality).
+ EXPECT_EQ(match_count, ordinal);
}
// Try to reproduce the crash seen in issue 1341577.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698