Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 6315001: Use DumpRenderTree instead of TestShell for generating (Closed)

Created:
9 years, 11 months ago by tony
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Erik does not do reviews, pam+watch_chromium.org, Aaron Boodman
Visibility:
Public.

Description

Use DumpRenderTree instead of TestShell for generating extensions documents. BUG=None TEST=Run chrome/common/exensions/docs/build/build.py. Extension documents should still be generated without errors. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71754

Patch Set 1 #

Patch Set 2 : build.sh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -37 lines) Patch
M chrome/common/extensions/docs/build/build.py View 7 chunks +40 lines, -36 lines 0 comments Download
M chrome/common/extensions/docs/build/build.sh View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
tony
I tested this on mac and linux and both seem to work (I can delete ...
9 years, 11 months ago (2011-01-13 18:31:26 UTC) #1
rafaelw
code lg. I've been trying all day to get a working build on windows (which ...
9 years, 11 months ago (2011-01-14 01:39:54 UTC) #2
Aaron Boodman
Wow, I can't believe how easy this change was! I imagine it is much faster, ...
9 years, 11 months ago (2011-01-14 01:45:53 UTC) #3
Aaron Boodman
My Windows machine is toast due to security gnomes. Matt says he has one that ...
9 years, 11 months ago (2011-01-18 23:07:18 UTC) #4
Matt Perry
Yep, seems to work! nit: can you edit build.sh and s/test_shell/DumpRenderTree?
9 years, 11 months ago (2011-01-18 23:34:57 UTC) #5
tony
On 2011/01/18 23:34:57, Matt Perry wrote: > Yep, seems to work! > > nit: can ...
9 years, 11 months ago (2011-01-19 01:00:10 UTC) #6
rafaelw1
+Kathy & Arne. If you guys are building docs via pre-built test_shell, we'll need to ...
9 years, 11 months ago (2011-01-19 01:10:21 UTC) #7
rafaelw
+Kathy & Arne. If you guys are building docs via pre-built test_shell, we'll need to ...
9 years, 11 months ago (2011-01-19 01:10:57 UTC) #8
kurrik.chromium
I build chrome so it looks like I'll get this. I believe Kathy has a ...
9 years, 11 months ago (2011-01-19 08:24:30 UTC) #9
rafaelw
Kathy, Let me know if you want/need help building or getting DumpRenderTree for whatever platform ...
9 years, 11 months ago (2011-01-19 17:22:25 UTC) #10
kathyw
9 years, 11 months ago (2011-01-19 17:37:22 UTC) #11
Thanks for the offer, Raf, but I should be OK. I'm using Linux, and
Aaron says he can get me the build for that.

-k-

On Wed, Jan 19, 2011 at 9:22 AM, Rafael Weinstein <rafaelw@chromium.org> wrote:
> Kathy,
> Let me know if you want/need help building or getting DumpRenderTree for
> whatever platform you make docs on.
> On Wed, Jan 19, 2011 at 12:24 AM, Arne Roomann-Kurrik <kurrik@chromium.org>
> wrote:
>>
>> I build chrome so it looks like I'll get this.  I believe Kathy has a
>> pre-built binary though.  Thanks for the heads up!
>> ~Arne
>>
>> On Tue, Jan 18, 2011 at 5:10 PM, Rafael Weinstein <rafaelw@google.com>
>> wrote:
>>>
>>> +Kathy & Arne.
>>> If you guys are building docs via  pre-built test_shell, we'll need to
>>> get you setup with a pre-built DumpRenderTree.
>>>
>>> On Tue, Jan 18, 2011 at 5:00 PM, <tony@chromium.org> wrote:
>>>>
>>>> On 2011/01/18 23:34:57, Matt Perry wrote:
>>>>>
>>>>> Yep, seems to work!
>>>>
>>>>> nit: can you edit build.sh and s/test_shell/DumpRenderTree?
>>>>
>>>> Fixed.  Do I need to notify the tech writers about this change?
>>>>
>>>> http://codereview.chromium.org/6315001/
>>>
>>
>
>

Powered by Google App Engine
This is Rietveld 408576698