Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 6314025: Implements PPB_Context3DTrusted_Dev. Also add CreateRaw/Initialize for proxy (Closed)

Created:
9 years, 11 months ago by piman
Modified:
9 years, 7 months ago
Reviewers:
neb
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Implements PPB_Context3DTrusted_Dev. Also add CreateRaw/Initialize for proxy This is the follow up to http://codereview.chromium.org/6293023/ BUG=none TEST=Pepper Flash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73000

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -22 lines) Patch
M ppapi/c/dev/ppb_context_3d_trusted_dev.h View 2 chunks +14 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_context_3d_impl.h View 4 chunks +10 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_context_3d_impl.cc View 7 chunks +185 lines, -18 lines 0 comments Download
M webkit/plugins/ppapi/ppb_surface_3d_impl.cc View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
piman
Parts of it is the code from your old CL.
9 years, 11 months ago (2011-01-28 01:22:16 UTC) #1
neb
9 years, 11 months ago (2011-01-28 06:18:50 UTC) #2
On 2011/01/28 01:22:16, piman wrote:
> Parts of it is the code from your old CL.

There are two lint errors in ppb_context_3d_impl.cc, other than that, looks
great! Thanks for doing this so quickly, you really helped me a lot.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698