People hate to read text so put a link directly to the file.

People hate to read text so put a link directly to the file.

TBR=thakis
TEST=presubmit check is clearer
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72336

[cbentzel, 2011-01-24 16:04:48]

On 2011/01/24 16:02:11, Marc-Antoine Ruel wrote:

LGTM

[Nico, 2011-01-24 16:08:25]

LG

*shrug*
On Jan 24, 2011 8:02 AM, <maruel@chromium.org> wrote:
> Reviewers: Nico,
>
> Description:
> People hate to read text so put a link directly to the file.
>
> TBR=thakis
> TEST=presubmit check is clearer
> BUG=none
>
>
> Please review this at http://codereview.chromium.org/6314017/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
> M PRESUBMIT.py
>
>
> Index: PRESUBMIT.py
> diff --git a/PRESUBMIT.py b/PRESUBMIT.py
> index
>
ffb668cd1e9bed5aa9beebabf853f7b5cb68e661..158d2ae6f82ed743d6ce934ec93d2b79b5d16f72

> 100644
> --- a/PRESUBMIT.py
> +++ b/PRESUBMIT.py
> @@ -89,7 +89,9 @@ def _CheckSubversionConfig(input_api, output_api):
> error_msg = (
> 'Please look at http://dev.chromium.org/developers/coding-style to\n'
> 'configure your subversion configuration file. This enables
> automatic\n'
> - 'properties to simplify the project maintenance.')
> + 'properties to simplify the project maintenance.\n'
> + 'Pro-tip: just download and install\n'
> + 'http://src.chromium.org/viewvc/chrome/trunk/tools/build/slave/config\n
')
>
> try:
> lines = open(path, 'r').read().splitlines()
>
>

[Nico, 2011-01-24 16:08:25]

Missing a space at eol
On Jan 24, 2011 8:02 AM, <maruel@chromium.org> wrote:
> Reviewers: Nico,
>
> Description:
> People hate to read text so put a link directly to the file.
>
> TBR=thakis
> TEST=presubmit check is clearer
> BUG=none
>
>
> Please review this at http://codereview.chromium.org/6314017/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
> M PRESUBMIT.py
>
>
> Index: PRESUBMIT.py
> diff --git a/PRESUBMIT.py b/PRESUBMIT.py
> index
>
ffb668cd1e9bed5aa9beebabf853f7b5cb68e661..158d2ae6f82ed743d6ce934ec93d2b79b5d16f72

> 100644
> --- a/PRESUBMIT.py
> +++ b/PRESUBMIT.py
> @@ -89,7 +89,9 @@ def _CheckSubversionConfig(input_api, output_api):
> error_msg = (
> 'Please look at http://dev.chromium.org/developers/coding-style to\n'
> 'configure your subversion configuration file. This enables
> automatic\n'
> - 'properties to simplify the project maintenance.')
> + 'properties to simplify the project maintenance.\n'
> + 'Pro-tip: just download and install\n'
> + 'http://src.chromium.org/viewvc/chrome/trunk/tools/build/slave/config\n
')
>
> try:
> lines = open(path, 'r').read().splitlines()
>
>