Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: chrome_frame/ready_mode/internal/ready_prompt_content.cc

Issue 6314016: Update the Ready Mode UI in response to feedback from UI leads, Chrome Frame ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_frame/ready_mode/internal/ready_prompt_content.cc
===================================================================
--- chrome_frame/ready_mode/internal/ready_prompt_content.cc (revision 72310)
+++ chrome_frame/ready_mode/internal/ready_prompt_content.cc (working copy)
@@ -4,15 +4,15 @@
#include "chrome_frame/ready_mode/internal/ready_prompt_content.h"
erikwright (departed) 2011/01/24 06:58:39 Oops. This is missing atlbase.h, atlwin.h, and Exd
robertshield 2011/01/24 16:10:21 Add them? ;-)
erikwright (departed) 2011/01/24 17:14:01 Yeah. Wanted to get this out for initial feedback
-#include <atlbase.h>
-#include <atlwin.h>
-
#include "base/logging.h"
#include "chrome_frame/ready_mode/internal/ready_mode_state.h"
#include "chrome_frame/ready_mode/internal/ready_prompt_window.h"
-ReadyPromptContent::ReadyPromptContent(ReadyModeState* ready_mode_state)
+ReadyPromptContent::ReadyPromptContent(ReadyModeState* ready_mode_state,
+ IWebBrowser2* web_browser)
: ready_mode_state_(ready_mode_state) {
+ web_browser->AddRef();
+ web_browser_.Attach(web_browser);
}
ReadyPromptContent::~ReadyPromptContent() {
@@ -29,7 +29,8 @@
// The window owns itself upon call to Initialize.
ReadyPromptWindow* new_window_ = new ReadyPromptWindow();
robertshield 2011/01/24 16:10:21 new_window_ is not a member so shouldn't have the
- window_ = new_window_->Initialize(frame, ready_mode_state_.release());
+ window_ = new_window_->Initialize(frame, ready_mode_state_.release(),
+ web_browser_);
return window_ != NULL;
}

Powered by Google App Engine
This is Rietveld 408576698