Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: webkit/glue/webkitclient_impl.cc

Issue 6314015: Revert 72259 - Bundle audio spatialization resources for use by the web audio... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webkitclient_impl.cc
===================================================================
--- webkit/glue/webkitclient_impl.cc (revision 72267)
+++ webkit/glue/webkitclient_impl.cc (working copy)
@@ -24,7 +24,6 @@
#include "base/synchronization/lock.h"
#include "base/time.h"
#include "base/utf_string_conversions.h"
-#include "grit/webkit_chromium_resources.h"
#include "grit/webkit_resources.h"
#include "grit/webkit_strings.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebCookie.h"
@@ -292,59 +291,6 @@
TRACE_EVENT_END(name, id, extra);
}
-namespace {
-
-WebData loadAudioSpatializationResource(const char* name) {
-#ifdef IDR_AUDIO_SPATIALIZATION_T000_P000
- const size_t kExpectedSpatializationNameLength = 31;
- if (strlen(name) != kExpectedSpatializationNameLength) {
- return WebData();
- }
-
- // Extract the azimuth and elevation from the resource name.
- int azimuth = 0;
- int elevation = 0;
- int values_parsed =
- sscanf(name, "IRC_Composite_C_R0195_T%3d_P%3d", &azimuth, &elevation);
- if (values_parsed != 2) {
- return WebData();
- }
-
- // The resource index values go through the elevations first, then azimuths.
- const int kAngleSpacing = 15;
-
- // 0 <= elevation <= 90 (or 315 <= elevation <= 345)
- // in increments of 15 degrees.
- int elevation_index =
- elevation <= 90 ? elevation / kAngleSpacing :
- 7 + (elevation - 315) / kAngleSpacing;
- bool is_elevation_index_good = 0 <= elevation_index && elevation_index < 10;
-
- // 0 <= azimuth < 360 in increments of 15 degrees.
- int azimuth_index = azimuth / kAngleSpacing;
- bool is_azimuth_index_good = 0 <= azimuth_index && azimuth_index < 24;
-
- const int kNumberOfElevations = 10;
- const int kNumberOfAudioResources = 240;
- int resource_index = kNumberOfElevations * azimuth_index + elevation_index;
- bool is_resource_index_good = 0 <= resource_index &&
- resource_index < kNumberOfAudioResources;
-
- if (is_azimuth_index_good && is_elevation_index_good &&
- is_resource_index_good) {
- const int kFirstAudioResourceIndex = IDR_AUDIO_SPATIALIZATION_T000_P000;
- base::StringPiece resource =
- GetDataResource(kFirstAudioResourceIndex + resource_index);
- return WebData(resource.data(), resource.size());
- }
-#endif // IDR_AUDIO_SPATIALIZATION_T000_P000
-
- NOTREACHED();
- return WebData();
-}
-
-} // namespace
-
WebData WebKitClientImpl::loadResource(const char* name) {
struct {
const char* name;
@@ -396,16 +342,10 @@
{ "linuxProgressValue", IDR_PROGRESS_VALUE },
#endif
};
-
- // Check the name prefix to see if it's an audio resource.
- if (StartsWithASCII(name, "IRC_Composite", true)) {
- return loadAudioSpatializationResource(name);
- } else {
- for (size_t i = 0; i < ARRAYSIZE_UNSAFE(resources); ++i) {
- if (!strcmp(name, resources[i].name)) {
- base::StringPiece resource = GetDataResource(resources[i].id);
- return WebData(resource.data(), resource.size());
- }
+ for (size_t i = 0; i < ARRAYSIZE_UNSAFE(resources); ++i) {
+ if (!strcmp(name, resources[i].name)) {
+ base::StringPiece resource = GetDataResource(resources[i].id);
+ return WebData(resource.data(), resource.size());
}
}
// TODO(jhawkins): Restore this NOTREACHED once WK stops sending in empty
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698