Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: net/base/dnsrr_resolver.h

Issue 6314010: Even more reordering the methods in headers and implementation in net/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/dnssec_keyset.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/dnsrr_resolver.h
diff --git a/net/base/dnsrr_resolver.h b/net/base/dnsrr_resolver.h
index 9cc5bb8167e32fd56b34e6fddee82eccec8cd4fa..3280774d653d47a0e45eef435e8dca202830a30e 100644
--- a/net/base/dnsrr_resolver.h
+++ b/net/base/dnsrr_resolver.h
@@ -26,6 +26,14 @@ struct RRResponse {
RRResponse();
~RRResponse();
+ // HasExpired returns true if |fetch_time| + |ttl| is less than
+ // |current_time|.
+ bool HasExpired(base::Time current_time) const;
+
+ // For testing only
+ bool ParseFromResponse(const uint8* data, unsigned len,
+ uint16 rrtype_requested);
+
// name contains the canonical name of the resulting domain. If the queried
// name was a CNAME then this can differ.
std::string name;
@@ -42,14 +50,6 @@ struct RRResponse {
// negative is true if this is a negative cache entry, i.e. is a placeholder
// to remember that a given RR doesn't exist.
bool negative;
-
- // HasExpired returns true if |fetch_time| + |ttl| is less than
- // |current_time|.
- bool HasExpired(base::Time current_time) const;
-
- // For testing only
- bool ParseFromResponse(const uint8* data, unsigned len,
- uint16 rrtype_requested);
};
class BoundNetLog;
@@ -69,6 +69,8 @@ class RRResolverJob;
class DnsRRResolver : public base::NonThreadSafe,
public NetworkChangeNotifier::Observer {
public:
+ typedef intptr_t Handle;
+
enum {
kInvalidHandle = 0,
};
@@ -79,8 +81,6 @@ class DnsRRResolver : public base::NonThreadSafe,
FLAG_WANT_DNSSEC = 1,
};
- typedef intptr_t Handle;
-
DnsRRResolver();
~DnsRRResolver();
« no previous file with comments | « no previous file | net/base/dnssec_keyset.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698