Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: net/base/upload_data_stream.h

Issue 6314010: Even more reordering the methods in headers and implementation in net/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/transport_security_state.cc ('k') | net/base/upload_data_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/upload_data_stream.h
diff --git a/net/base/upload_data_stream.h b/net/base/upload_data_stream.h
index 0d179d217bcfdd80c8d0915c84268e5fda856167..8583fb46b850bc69e0705dbb403781a0af2e20a4 100644
--- a/net/base/upload_data_stream.h
+++ b/net/base/upload_data_stream.h
@@ -16,13 +16,13 @@ class IOBuffer;
class UploadDataStream {
public:
+ ~UploadDataStream();
+
// Returns a new instance of UploadDataStream if it can be created and
// initialized successfully. If not, NULL will be returned and the error
// code will be set if the output parameter error_code is not empty.
static UploadDataStream* Create(UploadData* data, int* error_code);
- ~UploadDataStream();
-
// Returns the stream's buffer and buffer length.
IOBuffer* buf() const { return buf_; }
size_t buf_len() const { return buf_len_; }
@@ -44,6 +44,8 @@ class UploadDataStream {
bool eof() const { return eof_; }
private:
+ enum { kBufSize = 16384 };
+
// Protects from public access since now we have a static creator function
// which will do both creation and initialization and might return an error.
explicit UploadDataStream(UploadData* data);
@@ -59,7 +61,6 @@ class UploadDataStream {
// always at the front of the buffer. If we cannot send all of the buffer at
// once, then we memmove the remaining portion and back-fill the buffer for
// the next "write" call. buf_len_ indicates how much data is in the buffer.
- enum { kBufSize = 16384 };
scoped_refptr<IOBuffer> buf_;
size_t buf_len_;
« no previous file with comments | « net/base/transport_security_state.cc ('k') | net/base/upload_data_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698