Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Unified Diff: net/base/mock_host_resolver.cc

Issue 6314010: Even more reordering the methods in headers and implementation in net/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/mapped_host_resolver.h ('k') | net/base/net_log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/mock_host_resolver.cc
diff --git a/net/base/mock_host_resolver.cc b/net/base/mock_host_resolver.cc
index a1817a29db443d75e84fc1b5e81eeead9bed645e..dfce49ff36481fb546f5675087553ef9ef9e19a9 100644
--- a/net/base/mock_host_resolver.cc
+++ b/net/base/mock_host_resolver.cc
@@ -45,37 +45,8 @@ int CreateIPAddress(const std::string& host,
} // namespace
-MockHostResolverBase::MockHostResolverBase(bool use_caching)
- : use_caching_(use_caching) {
- Reset(NULL);
-}
-
MockHostResolverBase::~MockHostResolverBase() {}
-int MockHostResolverBase::Resolve(const RequestInfo& info,
- AddressList* addresses,
- CompletionCallback* callback,
- RequestHandle* out_req,
- const BoundNetLog& net_log) {
- if (synchronous_mode_) {
- callback = NULL;
- out_req = NULL;
- }
- return impl_->Resolve(info, addresses, callback, out_req, net_log);
-}
-
-void MockHostResolverBase::CancelRequest(RequestHandle req) {
- impl_->CancelRequest(req);
-}
-
-void MockHostResolverBase::AddObserver(Observer* observer) {
- impl_->AddObserver(observer);
-}
-
-void MockHostResolverBase::RemoveObserver(Observer* observer) {
- impl_->RemoveObserver(observer);
-}
-
void MockHostResolverBase::Reset(HostResolverProc* interceptor) {
synchronous_mode_ = false;
@@ -107,6 +78,35 @@ void MockHostResolverBase::Reset(HostResolverProc* interceptor) {
impl_.reset(new HostResolverImpl(proc, cache, 50u, NULL));
}
+int MockHostResolverBase::Resolve(const RequestInfo& info,
+ AddressList* addresses,
+ CompletionCallback* callback,
+ RequestHandle* out_req,
+ const BoundNetLog& net_log) {
+ if (synchronous_mode_) {
+ callback = NULL;
+ out_req = NULL;
+ }
+ return impl_->Resolve(info, addresses, callback, out_req, net_log);
+}
+
+void MockHostResolverBase::CancelRequest(RequestHandle req) {
+ impl_->CancelRequest(req);
+}
+
+void MockHostResolverBase::AddObserver(Observer* observer) {
+ impl_->AddObserver(observer);
+}
+
+void MockHostResolverBase::RemoveObserver(Observer* observer) {
+ impl_->RemoveObserver(observer);
+}
+
+MockHostResolverBase::MockHostResolverBase(bool use_caching)
+ : use_caching_(use_caching) {
+ Reset(NULL);
+}
+
//-----------------------------------------------------------------------------
struct RuleBasedHostResolverProc::Rule {
@@ -144,9 +144,6 @@ RuleBasedHostResolverProc::RuleBasedHostResolverProc(HostResolverProc* previous)
: HostResolverProc(previous) {
}
-RuleBasedHostResolverProc::~RuleBasedHostResolverProc() {
-}
-
void RuleBasedHostResolverProc::AddRule(const std::string& host_pattern,
const std::string& replacement) {
AddRuleForAddressFamily(host_pattern, ADDRESS_FAMILY_UNSPECIFIED,
@@ -258,6 +255,9 @@ int RuleBasedHostResolverProc::Resolve(const std::string& host,
host_resolver_flags, addrlist, os_error);
}
+RuleBasedHostResolverProc::~RuleBasedHostResolverProc() {
+}
+
//-----------------------------------------------------------------------------
WaitingHostResolverProc::WaitingHostResolverProc(HostResolverProc* previous)
« no previous file with comments | « net/base/mapped_host_resolver.h ('k') | net/base/net_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698