Issue 6314009: s/LEAK/POSSIBLE LEAK/ for some of the recently filed suppressions...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6314009: s/LEAK/POSSIBLE LEAK/ for some of the recently filed suppressions... (Closed)

Created:
9 years, 11 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

s/LEAK/POSSIBLE LEAK/ for some of the recently filed suppressions Filed http://code.google.com/p/drmemory/issues/detail?id=273 to find out why a separate suppression type is needed BUG=57910, 68307 TBR=glider TEST=DrM/FYI bot should become greener Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71810

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tools/valgrind/drmemory/suppressions.txt	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

9 years, 11 months ago (2011-01-24 12:36:04 UTC) #2

LGTM

On Wed, Jan 19, 2011 at 8:49 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> s/LEAK/POSSIBLE LEAK/ for some of the recently filed suppressions
> Filed http://code.google.com/p/drmemory/issues/detail?id=273 to find out why
> a
> separate suppression type is needed
> BUG=57910,68307
> TBR=glider
> TEST=DrM/FYI bot should become greener
>
> Please review this at http://codereview.chromium.org/6314009/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/drmemory/suppressions.txt
>
>
> Index: tools/valgrind/drmemory/suppressions.txt
> ===================================================================
> --- tools/valgrind/drmemory/suppressions.txt    (revision 71806)
> +++ tools/valgrind/drmemory/suppressions.txt    (working copy)
> @@ -57,7 +57,7 @@
>  ...
>  SHELL32.dll!ILSaveToStream*
>
> -LEAK
> +POSSIBLE LEAK
>  ...
>  SHELL32.dll!SHFileOperation*
>
> @@ -412,14 +412,14 @@
>  *!vp8_*
>
>  # http://crbug.com/57910
> -LEAK
> +POSSIBLE LEAK
>  ...
>  *!*inflateInit*
>  *!remoting::DecompressorZlib::InitStream
>  *!remoting::DecompressorZlib::Reset
>
>  # http://crbug.com/68307
> -LEAK
> +POSSIBLE LEAK
>  ...
>  *!PrintDlgExMock
>  ...
>
>
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow

Expand Messages | Collapse Messages