Issue 6314003: ARM: Implement DoModI stub in the lithium code generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6314003: ARM: Implement DoModI stub in the lithium code generator. (Closed)

Created:
9 years, 11 months ago by Karl Klose

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

ARM: Implement DoModI stub in the lithium code generator. BUG= TEST=

Patch Set 1 #

Patch Set 2 : Implement a generic deferred code for binary operations. #

Patch Set 3 : Delete unused method declaration. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -14 lines)			Patch
M	src/arm/lithium-arm.cc	View		1 chunk	+8 lines, -9 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1	3 chunks	+57 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM, will you add some inline mod operations e.g for powers of 2 in a ...

9 years, 11 months ago (2011-01-14 10:32:11 UTC) #2

Karl Klose

9 years, 11 months ago (2011-01-14 11:34:26 UTC) #3

Yes, I will provide better implementations for both ModI and DivI in a later cl.
On 2011/01/14 10:32:11, Søren Gjesse wrote:
> LGTM,
> 
> will you add some inline mod operations e.g for powers of 2 in a separate
> change?

Expand Messages | Collapse Messages