Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 6314001: remote_access.sh: remove dependence on ssh-agent (Closed)

Created:
9 years, 11 months ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
Reviewers:
kmixter1, sosa
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

remote_access.sh: remove dependence on ssh-agent Change-Id: I68d02f5630bd885894ca69728254f2a5ba5cc2aa BUG=n0ne TEST=Verified I could successfully ssh. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=78476ab

Patch Set 1 #

Patch Set 2 : D'oh. Forget the other two commands. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -14 lines) Patch
M remote_access.sh View 1 2 chunks +9 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mandeep Singh Baines
9 years, 11 months ago (2011-01-13 18:15:58 UTC) #1
kmixter1
9 years, 11 months ago (2011-01-13 18:55:29 UTC) #2
LGTM - nice improvement

On Thu, Jan 13, 2011 at 10:15 AM, <msb@chromium.org> wrote:

> Reviewers: sosa, kmixter1,
>
> Description:
> remote_access.sh: remove dependence on ssh-agent
>
> Change-Id: I68d02f5630bd885894ca69728254f2a5ba5cc2aa
>
> BUG=n0ne
> TEST=Verified I could successfully ssh.
>
> Please review this at http://codereview.chromium.org/6314001/
>
> SVN Base: http://git.chromium.org/git/crosutils.git@master
>
> Affected files:
>  M remote_access.sh
>
>
> Index: remote_access.sh
> diff --git a/remote_access.sh b/remote_access.sh
> index
>
794deff8e755ed0a98a35513016e86c3239cdbad..5c1faf6e02e2d5dd0072747eeacb209da9ef336d
> 100644
> --- a/remote_access.sh
> +++ b/remote_access.sh
> @@ -29,8 +29,9 @@ function remote_rsync_from() {
>  }
>
>  function remote_sh() {
> -  REMOTE_OUT=$(ssh -p ${FLAGS_ssh_port} -o StrictHostKeyChecking=no -o \
> -    UserKnownHostsFile=$TMP_KNOWN_HOSTS root@$FLAGS_remote "$@")
> +  REMOTE_OUT=$(ssh -p ${FLAGS_ssh_port} -o StrictHostKeyChecking=no \
> +    -o UserKnownHostsFile=$TMP_KNOWN_HOSTS -i $TMP_PRIVATE_KEY \
> +    root@$FLAGS_remote "$@")
>   return ${PIPESTATUS[0]}
>  }
>
> @@ -40,15 +41,8 @@ function remote_sh_allow_changed_host_key() {
>  }
>
>  function set_up_remote_access() {
> -  if [ -z "$SSH_AGENT_PID" ]; then
> -    eval $(ssh-agent)
> -    OWN_SSH_AGENT=1
> -  else
> -    OWN_SSH_AGENT=0
> -  fi
>   cp $FLAGS_private_key $TMP_PRIVATE_KEY
>   chmod 0400 $TMP_PRIVATE_KEY
> -  ssh-add $TMP_PRIVATE_KEY
>
>   # Verify the client is reachable before continuing
>   echo "Initiating first contact with remote host"
>
>
>

Powered by Google App Engine
This is Rietveld 408576698