Issue 6313011: DOMUI: Polish up the 'Import Data' overlay.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6313011: DOMUI: Polish up the 'Import Data' overlay. (Closed)

Created:
9 years, 11 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DOMUI: Polish up the 'Import Data' overlay. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72184

Patch Set 3 : Narrow a CSS selector. #

Patch Set 4 : Narrow a CSS selector. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -16 lines)			Patch
M	chrome/browser/resources/options/import_data_overlay.css	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/import_data_overlay.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/options_page.css	View	1 2	3 chunks	+23 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

LGTM http://codereview.chromium.org/6313011/diff/1/chrome/browser/resources/options/options_page.css File chrome/browser/resources/options/options_page.css (right): http://codereview.chromium.org/6313011/diff/1/chrome/browser/resources/options/options_page.css#newcode39 chrome/browser/resources/options/options_page.css:39: position: fixed; I think left: goes after this, ...

9 years, 11 months ago (2011-01-21 19:44:43 UTC) #2

James Hawkins

I did add another padding, so you can check that out. http://codereview.chromium.org/6313011/diff/1/chrome/browser/resources/options/options_page.css File chrome/browser/resources/options/options_page.css (right): ...

9 years, 11 months ago (2011-01-21 19:51:04 UTC) #3

LGTM