Add possibility to divide chrome users into groups of equal size, and change ...

Add possibility to divide chrome users into groups of equal size, and change promo code to reflect sync promo.

BUG=68671, 68672
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72374

[arv (Not doing code reviews), 2011-01-24 18:15:11]

My main concern is that someone comes along in the future and does not
understand how this is used and we end up with "strange" tips.

http://codereview.chromium.org/6313009/diff/5/chrome/browser/resources/new_ne...
File chrome/browser/resources/new_new_tab.html (right):

http://codereview.chromium.org/6313009/diff/5/chrome/browser/resources/new_ne...
chrome/browser/resources/new_new_tab.html:136: <span class="link"><span
class="link-color" id="actionlink"></span></span>
action-link

http://codereview.chromium.org/6313009/diff/5/chrome/browser/resources/new_ne...
File chrome/browser/resources/new_new_tab.js (right):

http://codereview.chromium.org/6313009/diff/5/chrome/browser/resources/new_ne...
chrome/browser/resources/new_new_tab.js:921: * @param {bool=} close If true,
show a close link next to the notification.
boolean

http://codereview.chromium.org/6313009/diff/5/chrome/browser/resources/new_ne...
chrome/browser/resources/new_new_tab.js:923: function showNotification(message,
actionText, opt_f, opt_delay, opt_close) {
I think we should create a component for this soon...

Can you add?

// TODO(arv): Create a notification component.

http://codereview.chromium.org/6313009/diff/5/chrome/browser/web_resource/web...
File chrome/browser/web_resource/web_resource_service.cc (right):

http://codereview.chromium.org/6313009/diff/5/chrome/browser/web_resource/web...
chrome/browser/web_resource/web_resource_service.cc:457:
(prefs_->FindPreference(prefs::kNTPPromoGroup) ?
useless parentheses

http://codereview.chromium.org/6313009/diff/5/chrome/common/pref_names.cc
File chrome/common/pref_names.cc (right):

http://codereview.chromium.org/6313009/diff/5/chrome/common/pref_names.cc#new...
chrome/common/pref_names.cc:1033: const char kNTPPromoBuild[] =
"ntp.promo_build";
Sort these alphabetically?

[Miranda Callahan, 2011-01-24 18:39:22]

I agree completely with your main concern about future people trying to set
strange tips.

I've filed bug 70634 against myself to get a promo server set up, and made
reference to it in the WebResourceService class description.

http://codereview.chromium.org/6313009/diff/5/chrome/browser/resources/new_ne...
File chrome/browser/resources/new_new_tab.html (right):

http://codereview.chromium.org/6313009/diff/5/chrome/browser/resources/new_ne...
chrome/browser/resources/new_new_tab.html:136: <span class="link"><span
class="link-color" id="actionlink"></span></span>
On 2011/01/24 18:15:11, arv wrote:
> action-link

Done.

http://codereview.chromium.org/6313009/diff/5/chrome/browser/resources/new_ne...
File chrome/browser/resources/new_new_tab.js (right):

http://codereview.chromium.org/6313009/diff/5/chrome/browser/resources/new_ne...
chrome/browser/resources/new_new_tab.js:921: * @param {bool=} close If true,
show a close link next to the notification.
On 2011/01/24 18:15:11, arv wrote:
> boolean

Done.

http://codereview.chromium.org/6313009/diff/5/chrome/browser/resources/new_ne...
chrome/browser/resources/new_new_tab.js:923: function showNotification(message,
actionText, opt_f, opt_delay, opt_close) {
On 2011/01/24 18:15:11, arv wrote:
> I think we should create a component for this soon...
> 
> Can you add?
> 
> // TODO(arv): Create a notification component.

Done.

http://codereview.chromium.org/6313009/diff/5/chrome/browser/web_resource/web...
File chrome/browser/web_resource/web_resource_service.cc (right):

http://codereview.chromium.org/6313009/diff/5/chrome/browser/web_resource/web...
chrome/browser/web_resource/web_resource_service.cc:457:
(prefs_->FindPreference(prefs::kNTPPromoGroup) ?
On 2011/01/24 18:15:11, arv wrote:
> useless parentheses

I wish they were, because they're kind of ugly -- unfortunately, + has higher
precedence than the ternary ?, so the compiler gives an error on trying to add a
double to a const Preference* without the parens.

http://codereview.chromium.org/6313009/diff/5/chrome/common/pref_names.cc
File chrome/common/pref_names.cc (right):

http://codereview.chromium.org/6313009/diff/5/chrome/common/pref_names.cc#new...
chrome/common/pref_names.cc:1033: const char kNTPPromoBuild[] =
"ntp.promo_build";
On 2011/01/24 18:15:11, arv wrote:
> Sort these alphabetically?

Resorted the whole kNTPPromo group alphabetically -- except for Start and End,
which I left together as a pair.

[arv (Not doing code reviews), 2011-01-24 19:41:33]

LGTM

http://codereview.chromium.org/6313009/diff/51001/chrome/browser/resources/ne...
File chrome/browser/resources/new_new_tab.html (right):

http://codereview.chromium.org/6313009/diff/51001/chrome/browser/resources/ne...
chrome/browser/resources/new_new_tab.html:139: <span class="link"><span
class="link-color" id="action-link"></span></span>
Long line

(please be careful when wrapping since whitespace is significant between spans)