Issue 6313007: Fix crash in PluginService if the keys are null. It's still unclear why this...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6313007: Fix crash in PluginService if the keys are null. It's still unclear why this... (Closed)

Created:
9 years, 11 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
amit

CC:
chromium-reviews, darin-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix crash in PluginService if the keys are null. It's still unclear why this is happening now as opposed to before. This change just fixes the crash in the meantime. BUG=70317 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72083

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/plugin_service.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

amit

9 years, 11 months ago (2011-01-21 01:18:55 UTC) #2

ok

On Thu, Jan 20, 2011 at 5:05 PM, <jam@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Fix crash in PluginService if the keys are null.  It's still unclear why
> this is
> happening now as opposed to before.  This change just fixes the crash in
> the
> meantime.
>
> BUG=70317
>
> Please review this at http://codereview.chromium.org/6313007/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/plugin_service.cc
>
>
> Index: chrome/browser/plugin_service.cc
> ===================================================================
> --- chrome/browser/plugin_service.cc    (revision 71973)
> +++ chrome/browser/plugin_service.cc    (working copy)
> @@ -218,8 +218,10 @@
>   // Release the events since they're owned by RegKey, not WaitableEvent.
>   hkcu_watcher_.StopWatching();
>   hklm_watcher_.StopWatching();
> -  hkcu_event_->Release();
> -  hklm_event_->Release();
> +  if (hkcu_event_.get())
> +    hkcu_event_->Release();
> +  if (hklm_event_.get())
> +    hklm_event_->Release();
>  #endif
>  }
>
>
>
>

Expand Messages | Collapse Messages