Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: chrome/browser/ui/cocoa/task_manager_mac.h

Issue 6312178: Highlight background pages in task manager if user clicks View Background Pages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome
Patch Set: Review feedback Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/cocoa/task_manager_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/task_manager_mac.h
diff --git a/chrome/browser/ui/cocoa/task_manager_mac.h b/chrome/browser/ui/cocoa/task_manager_mac.h
index 75c9811ec1fe969210d8a78bbc4f80d7aaf6fe41..211a86d05ac84a4df2c8e1f55f0a14da0241375d 100644
--- a/chrome/browser/ui/cocoa/task_manager_mac.h
+++ b/chrome/browser/ui/cocoa/task_manager_mac.h
@@ -29,6 +29,7 @@ class TaskManagerMac;
TaskManagerMac* taskManagerObserver_; // weak
TaskManager* taskManager_; // weak
TaskManagerModel* model_; // weak
+ bool highlightBackgroundResources_;
scoped_nsobject<WindowSizeAutosaver> size_saver_;
@@ -39,10 +40,14 @@ class TaskManagerMac;
// Descriptor of the current sort column.
scoped_nsobject<NSSortDescriptor> currentSortDescriptor_;
+
+ // Color we use for background resources.
+ scoped_nsobject<NSColor> backgroundResourceColor_;
}
// Creates and shows the task manager's window.
-- (id)initWithTaskManagerObserver:(TaskManagerMac*)taskManagerObserver;
+- (id)initWithTaskManagerObserver:(TaskManagerMac*)taskManagerObserver
+ highlightBackgroundResources:(bool)highlightBackgroundResources;
// Refreshes all data in the task manager table.
- (void)reloadData;
@@ -65,7 +70,7 @@ class TaskManagerMac;
class TaskManagerMac : public TaskManagerModelObserver,
public TableRowNSImageCache::Table {
public:
- TaskManagerMac(TaskManager* task_manager);
+ TaskManagerMac(TaskManager* task_manager, bool highlight_background);
virtual ~TaskManagerMac();
// TaskManagerModelObserver
@@ -83,8 +88,9 @@ class TaskManagerMac : public TaskManagerModelObserver,
virtual SkBitmap GetIcon(int r) const;
// Creates the task manager if it doesn't exist; otherwise, it activates the
- // existing task manager window.
- static void Show();
+ // existing task manager window. Highlights background resources if
+ // |highlight_background_resources| is true.
+ static void Show(bool highlight_background_resources);
// Returns the TaskManager observed by |this|.
TaskManager* task_manager() { return task_manager_; }
@@ -94,6 +100,9 @@ class TaskManagerMac : public TaskManagerModelObserver,
// Returns the cocoa object. Used for testing.
TaskManagerWindowController* cocoa_controller() { return window_controller_; }
+
+ // Returns true if the resource at this location is a background resource.
+ bool IsBackgroundRow(int row) const;
private:
// The task manager.
TaskManager* const task_manager_; // weak
@@ -108,6 +117,9 @@ class TaskManagerMac : public TaskManagerModelObserver,
// Caches favicons for all rows. Needs to be initalized after |model_|.
TableRowNSImageCache icon_cache_;
+ // If true, highlight background resources.
+ bool highlight_background_resources_;
+
// An open task manager window. There can only be one open at a time. This
// is reset to NULL when the window is closed.
static TaskManagerMac* instance_;
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/cocoa/task_manager_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698