Issue 6312176: cros_workon: fix --help to return an exit code of 0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6312176: cros_workon: fix --help to return an exit code of 0 (Closed)

Created:
9 years, 10 months ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
diandersAtChromium, anush

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/dev-util.git@master

Visibility:
Public.

Description

cros_workon: fix --help to return an exit code of 0 BUG=n0ne TEST=cros_workon --help && echo "test passed" Change-Id: I4d0835b0651f70256e7df82a174fbc8d025cba88 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=db08142

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	host/cros_workon	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

anush

9 years, 10 months ago (2011-02-05 19:42:58 UTC) #2

lgtm

On Sat, Feb 5, 2011 at 11:32 AM,  <msb@chromium.org> wrote:
> Reviewers: diandersAtChromium, anush,
>
> Description:
> cros_workon: fix --help to return an exit code of 0
>
> BUG=n0ne
> TEST=cros_workon --help && echo "test passed"
>
> Change-Id: I4d0835b0651f70256e7df82a174fbc8d025cba88
>
> Please review this at http://codereview.chromium.org/6312176/
>
> SVN Base: http://git.chromium.org/git/dev-util.git@master
>
> Affected files:
>  M host/cros_workon
>
>
> Index: host/cros_workon
> diff --git a/host/cros_workon b/host/cros_workon
> index
>
9632ea6f9220373c83c31b689aa59e756e1f1cd8..d991356c55ca3bf44d288d9df65a297a3f830c6f
> 100755
> --- a/host/cros_workon
> +++ b/host/cros_workon
> @@ -31,7 +31,7 @@ commands:
>   list:  List of live ebuilds (workon ebuilds if --all)
>   list-all:  List all of the live ebuilds for all setup boards
>   iterate:  For each ebuild, cd to the source dir and run a commond"
> -FLAGS "$@" || exit 1
> +FLAGS "$@" || { [ "${FLAGS_help}" = "${FLAGS_TRUE}" ]  && exit 0; } || exit
> 1
>  eval set -- "${FLAGS_ARGV}"
>
>
>
>
>

Expand Messages | Collapse Messages