In the chroot, don't do any path mucking. Just run chromite.

In the chroot, don't do any path mucking.  Just run chromite.

Change-Id: I416d4d1601ee157ae808eaa1f0a2c08d688d4c8e

BUG=chromium-os:11772
TEST=Ran chromite a few different ways inside and outside chroot.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=194da01

[diandersAtChromium, 2011-02-05 00:25:07]

Richard,

I think this should patch things finish up the wrapper changes we talked about. 
After this is pushed, I'll submit a request to get the depot_tools copy updated.

Thanks!

[jrbarnette, 2011-02-07 19:51:23]

I have a comment on what looks like a pre-existing bug introduced
in the last round.  The new code looks OK, but I'd like to see the final
product before I weigh in definitively.

http://codereview.chromium.org/6312167/diff/1/bin/chromite
File bin/chromite (right):

http://codereview.chromium.org/6312167/diff/1/bin/chromite#newcode53
bin/chromite:53: sys.path = path + sys.path
I just now noticed this, though I should have noticed before:  I believe
this will cause sys.path gradually to accumulate all the paths yielded up
by Search(), whether or not the path is needed.  I don't think that's right:
we should add only one directory to the path (the one that actually turned
out to be the one we needed).

[diandersAtChromium, 2011-02-07 21:30:49]

Richard,

I've pointed out the bit of code that should delete bad directories from the
path.  Can you take another look?  

I'm happy to submit a patch that makes this bit of code stand out a little more.
 If you think it would help, I could make the "except ImportError" be a "pass",
then move the two statements out of the exception handler?

Let me know.  Thanks!

-Doug

[diandersAtChromium, 2011-02-07 21:31:02]

http://codereview.chromium.org/6312167/diff/1/bin/chromite
File bin/chromite (right):

http://codereview.chromium.org/6312167/diff/1/bin/chromite#newcode53
bin/chromite:53: sys.path = path + sys.path
It looks like the paths are deleted in the "except ImportError" case.  See
below.  Does that look OK?

http://codereview.chromium.org/6312167/diff/1/bin/chromite#newcode62
bin/chromite:62: sys.path = sys.path[len(path):]
Paths are deleted here.

[jrbarnette, 2011-02-08 00:46:06]

OK, I'm satisfied as is.

LGTM!

http://codereview.chromium.org/6312167/diff/1/bin/chromite
File bin/chromite (right):

http://codereview.chromium.org/6312167/diff/1/bin/chromite#newcode62
bin/chromite:62: sys.path = sys.path[len(path):]
On 2011/02/07 21:31:02, diandersAtChromium wrote:
> Paths are deleted here.

Ah, I missed this.