Issue 6312160: Map Views to Profiles directly from their window, eliminating the need...

Issue 6312160: Map Views to Profiles directly from their window, eliminating the need... (Closed)

Created:
9 years, 10 months ago by dmazzoni

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, Paweł Hajdan Jr., Miranda Callahan, Chaitanya

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Map Views to Profiles directly from their window, eliminating the need for AccessibleViewHelper. BUG=none TEST=Modified existing unit test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74127

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 6

Patch Set 5 : '' #

Patch Set 6 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -522 lines)			Patch
M	chrome/browser/chromeos/login/existing_user_view.h	View	1 2 3 4 5	2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/existing_user_view.cc	View	1 2 3 4 5	2 chunks	+1 line, -8 lines	0 comments	Download
M	chrome/browser/chromeos/login/guest_user_view.h	View	1 2 3 4 5	2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/guest_user_view.cc	View	1 2 3 4 5	2 chunks	+1 line, -8 lines	0 comments	Download
M	chrome/browser/chromeos/login/network_selection_view.h	View	1 2 3 4 5	2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/network_selection_view.cc	View	1 2 3 4 5	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/login/new_user_view.cc	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/password_changed_view.cc	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/screen_lock_view.h	View	1 2 3 4 5	2 chunks	+1 line, -7 lines	0 comments	Download
M	chrome/browser/chromeos/login/screen_lock_view.cc	View	1 2 3 4 5	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/login/screen_locker_browsertest.cc	View	1 2 3 4 5	3 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/update_view.h	View	1 2 3 4 5	2 chunks	+1 line, -7 lines	0 comments	Download
M	chrome/browser/chromeos/login/update_view.cc	View	1 2 3 4 5	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_image_view.h	View	1 2 3 4 5	3 chunks	+1 line, -8 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_image_view.cc	View	1 2 3 4 5	2 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_accessibility_helper.h	View	1 2 3 4 5	4 chunks	+2 lines, -25 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_accessibility_helper.cc	View	1 2 3 4 5	3 chunks	+5 lines, -51 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.cc	View	1 2 3 4 5	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/about_chrome_view.h	View	1 2 3 4 5	3 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/ui/views/about_chrome_view.cc	View	1 2 3 4 5	2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/accessibility_event_router_views.h	View	1 2 3 4 5	6 chunks	+1 line, -46 lines	0 comments	Download
M	chrome/browser/ui/views/accessibility_event_router_views.cc	View	1 2 3 4 5	4 chunks	+19 lines, -89 lines	0 comments	Download
M	chrome/browser/ui/views/accessibility_event_router_views_unittest.cc	View	1 2 3 4 5	5 chunks	+40 lines, -37 lines	0 comments	Download
D	chrome/browser/ui/views/accessible_view_helper.h	View	1 2 3 4 5	1 chunk	+0 lines, -83 lines	0 comments	Download
D	chrome/browser/ui/views/accessible_view_helper.cc	View	1 2 3 4 5	1 chunk	+0 lines, -89 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.h	View	1 2 3 4 5	2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 2 3 4 5	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4 5	2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dmazzoni

Thanks! I was able to get rid of some more code, if you want to ...

9 years, 10 months ago (2011-02-05 01:22:09 UTC) #3

sky

SLGTM http://codereview.chromium.org/6312160/diff/4004/chrome/browser/chromeos/login/wizard_accessibility_helper.h File chrome/browser/chromeos/login/wizard_accessibility_helper.h (left): http://codereview.chromium.org/6312160/diff/4004/chrome/browser/chromeos/login/wizard_accessibility_helper.h#oldcode10 chrome/browser/chromeos/login/wizard_accessibility_helper.h:10: #include <vector> Can this include be removed now? ...

9 years, 10 months ago (2011-02-07 17:07:11 UTC) #4

dmazzoni

9 years, 10 months ago (2011-02-08 04:00:09 UTC) #5

http://codereview.chromium.org/6312160/diff/4004/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/wizard_accessibility_helper.h (left):

http://codereview.chromium.org/6312160/diff/4004/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/wizard_accessibility_helper.h:10: #include
<vector>
On 2011/02/07 17:07:11, sky wrote:
> Can this include be removed now?

Yes, both <map> and <vector> can be removed, thanks!

http://codereview.chromium.org/6312160/diff/4004/chrome/browser/ui/views/acce...
File chrome/browser/ui/views/accessibility_event_router_views.h (left):

http://codereview.chromium.org/6312160/diff/4004/chrome/browser/ui/views/acce...
chrome/browser/ui/views/accessibility_event_router_views.h:13: #include
"base/hash_tables.h"
On 2011/02/07 17:07:11, sky wrote:
> Can this be nuked?

Done.

http://codereview.chromium.org/6312160/diff/4004/chrome/browser/ui/views/acce...
chrome/browser/ui/views/accessibility_event_router_views.h:25: #if
defined(COMPILER_GCC)
On 2011/02/07 17:07:11, sky wrote:
> Can this be nuked?

Done.

Expand Messages | Collapse Messages