Remove wstring from RVH's run Javascript command....

chrome/test/pyautolib/pyautolib.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/scoped_ptr.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/test/automation/extension_proxy.h"
 #include "chrome/test/automation/tab_proxy.h"
@@ skipping 223 matching lines @@
       automation()->GetBrowserWindow(0);  // Window doesn't matter.
   EXPECT_TRUE(browser_proxy.get());
   if (!browser_proxy.get())
     return false;
 
   std::string s;
   EXPECT_TRUE(browser_proxy->GetBookmarksAsJSON(&s));
   return s;
 }
 
-bool PyUITestBase::AddBookmarkGroup(std::wstring& parent_id, int index,
-                                    std::wstring& title) {
+bool PyUITestBase::AddBookmarkGroup(const std::wstring& parent_id, int index,

[Nirnimesh, 2011/02/04 21:59:19]

string16 here?

[Avi (use Gerrit), 2011/02/04 23:02:11]

Done.

+                                    const std::wstring& title) {
   scoped_refptr<BrowserProxy> browser_proxy =
       automation()->GetBrowserWindow(0);  // Window doesn't matter.
   EXPECT_TRUE(browser_proxy.get());
   if (!browser_proxy.get())
     return false;
 
-  return browser_proxy->AddBookmarkGroup(StringToId(parent_id), index, title);
+  return browser_proxy->AddBookmarkGroup(StringToId(parent_id),
+                                         index,
+                                         WideToUTF16Hack(title));
 }
 
-bool PyUITestBase::AddBookmarkURL(std::wstring& parent_id, int index,
-                                  std::wstring& title, std::wstring& url) {
+bool PyUITestBase::AddBookmarkURL(const std::wstring& parent_id, int index,
+                                  const std::wstring& title,
+                                  const std::wstring& url) {
   scoped_refptr<BrowserProxy> browser_proxy =
       automation()->GetBrowserWindow(0);  // Window doesn't matter.
   EXPECT_TRUE(browser_proxy.get());
   if (!browser_proxy.get())
     return false;
 
   return browser_proxy->AddBookmarkURL(StringToId(parent_id),
-                                       index, title,
+                                       index,
+                                       WideToUTF16Hack(title),
                                        GURL(WideToUTF8(url)));
 }
 
 bool PyUITestBase::ReparentBookmark(
     std::wstring& id, std::wstring& new_parent_id, int index) {
   scoped_refptr<BrowserProxy> browser_proxy =
       automation()->GetBrowserWindow(0);  // Window doesn't matter.
   EXPECT_TRUE(browser_proxy.get());
   if (!browser_proxy.get())
     return false;
 
   return browser_proxy->ReparentBookmark(StringToId(id),
                                          StringToId(new_parent_id),
                                          index);
 }
 
 bool PyUITestBase::SetBookmarkTitle(std::wstring& id, std::wstring& title) {
   scoped_refptr<BrowserProxy> browser_proxy =
       automation()->GetBrowserWindow(0);  // Window doesn't matter.
   EXPECT_TRUE(browser_proxy.get());
   if (!browser_proxy.get())
     return false;
 
-  return browser_proxy->SetBookmarkTitle(StringToId(id), title);
+  return browser_proxy->SetBookmarkTitle(StringToId(id),
+                                         WideToUTF16Hack(title));
 }
 
 bool PyUITestBase::SetBookmarkURL(std::wstring& id, std::wstring& url) {
   scoped_refptr<BrowserProxy> browser_proxy =
       automation()->GetBrowserWindow(0);  // Window doesn't matter.
   EXPECT_TRUE(browser_proxy.get());
   if (!browser_proxy.get())
     return false;
 
   return browser_proxy->SetBookmarkURL(StringToId(id), GURL(WideToUTF8(url)));
@@ skipping 25 matching lines @@
   return response;
 }
 
 std::wstring PyUITestBase::ExecuteJavascript(const std::wstring& script,
                                              int window_index,
                                              int tab_index,
                                              const std::wstring& frame_xpath) {
   scoped_refptr<BrowserProxy> browser_proxy =
       automation()->GetBrowserWindow(window_index);
   EXPECT_TRUE(browser_proxy.get());
-  std::wstring response;
   if (!browser_proxy.get())
-    return response;
+    return std::wstring();
   scoped_refptr<TabProxy> tab_proxy =
       browser_proxy->GetTab(tab_index);
   EXPECT_TRUE(tab_proxy.get());
   if (!tab_proxy.get())
-    return response;
+    return std::wstring();
 
-  EXPECT_TRUE(tab_proxy->ExecuteAndExtractString(frame_xpath, script,
+  string16 response;
+  EXPECT_TRUE(tab_proxy->ExecuteAndExtractString(WideToUTF16Hack(frame_xpath),
+                                                 WideToUTF16Hack(script),
                                                  &response));
-  return response;
+  return UTF16ToWideHack(response);
 }
 
 std::wstring PyUITestBase::GetDOMValue(const std::wstring& expr,
                                        int window_index,
                                        int tab_index,
                                        const std::wstring& frame_xpath) {
   std::wstring script = std::wstring(L"window.domAutomationController.send(") +
       expr + std::wstring(L")");
   return ExecuteJavascript(script, window_index, tab_index, frame_xpath);
 }
@@ skipping 26 matching lines @@
   // TODO(phadjan.jr): figure out a way to unambiguously report error.
   if (!browser_proxy.get())
     return cookie_val;
   scoped_refptr<TabProxy> tab_proxy = browser_proxy->GetTab(tab_index);
   EXPECT_TRUE(tab_proxy.get());
   if (!tab_proxy.get())
     return cookie_val;
   EXPECT_TRUE(tab_proxy->GetCookies(cookie_url, &cookie_val));
   return cookie_val;
 }