Issue 6312124: X64: Implement FixedArrayLength, BoundsCheck, LoadElements,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6312124: X64: Implement FixedArrayLength, BoundsCheck, LoadElements, (Closed)

Created:
9 years, 10 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

X64: Implement FixedArrayLength, BoundsCheck, LoadElements, LoadKeyedFastElement in lithium codegen. Tested locally by hardcoding DoTaggedToI to convert smis to untagged. Committed: http://code.google.com/p/v8/source/detail?r=6625

Patch Set 1 #

Total comments: 1

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -12 lines)			Patch
	M	src/x64/lithium-codegen-x64.cc	View		4 chunks	+36 lines, -4 lines	1 comment	Download
	M	src/x64/lithium-x64.cc	View		3 chunks	+12 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Rico

9 years, 10 months ago (2011-02-03 16:56:47 UTC) #2

LGTM

http://codereview.chromium.org/6312124/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/6312124/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:1724: __ cmpq(ToRegister(instr->index()),
ToOperand(instr->length()));
Maybe we should create a macro, TO_REGISTER_OR_OPERAND, we are going to do this
a lot! I am fine with it not being in this change though.

Expand Messages | Collapse Messages