Issue 6312112: Fix recent change which prevented mount_gpt_image from running outside chroot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6312112: Fix recent change which prevented mount_gpt_image from running outside chroot. (Closed)

Created:
9 years, 10 months ago by DaleCurtis

Modified:
9 years, 7 months ago

Reviewers:
Greg Spencer (Chromium), anush

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

Fix recent change which prevented mount_gpt_image from running outside chroot. Change-Id: Id58de45b72522077179024ee0310c70d2af1a497 BUG=chromium-os:4230 TEST=Ran mount_gpt_image.sh inside/outside chroot. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d569a90

Patch Set 1 #

Patch Set 2 : Quote path in case of spaces. #

Patch Set 3 : Typo fix. #

Total comments: 2

Patch Set 4 : Switch to SRC_ROOT #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	mount_gpt_image.sh	View	1 2 3	1 chunk	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Greg Spencer (Chromium)

LGTM except for the nit below. http://codereview.chromium.org/6312112/diff/1002/mount_gpt_image.sh File mount_gpt_image.sh (right): http://codereview.chromium.org/6312112/diff/1002/mount_gpt_image.sh#newcode32 mount_gpt_image.sh:32: INSTALL_ROOT="$GCLIENT_ROOT/src/platform/installer/" This should ...

9 years, 10 months ago (2011-02-03 04:19:54 UTC) #2

DaleCurtis

9 years, 10 months ago (2011-02-03 04:29:45 UTC) #3

Thanks! Pushing.

http://codereview.chromium.org/6312112/diff/1002/mount_gpt_image.sh
File mount_gpt_image.sh (right):

http://codereview.chromium.org/6312112/diff/1002/mount_gpt_image.sh#newcode32
mount_gpt_image.sh:32: INSTALL_ROOT="$GCLIENT_ROOT/src/platform/installer/"
On 2011/02/03 04:19:56, Greg Spencer (Chromium) wrote:
> This should probably be $SRC_ROOT instead of $GCLIENT_ROOT/src

Done.

Expand Messages | Collapse Messages