Allow CROS_WORKON_SRCROOT to be used outside the chroot.

Allow CROS_WORKON_SRCROOT to be used outside the chroot.

Change-Id: I0a981b84afe2790e9c710113ee9a225f7548dfcb

BUG=None
TEST='chromite workon x86-mario list --all' outside repo and chroot with CROS_WORKON_SRCROOT set
TEST='chromite workon x86-mario list --all' inside repo and outside chroot with CROS_WORKON_SRCROOT set
TEST='chromite workon x86-mario list --all' outside repo and chroot with CROS_WORKON_SRCROOT not set
TEST='chromite workon x86-mario list --all' inside repo and outside chroot with CROS_WORKON_SRCROOT not set
TEST='chromite workon x86-mario list --all' inside chroot

[diandersAtChromium, 2011-02-01 23:08:09]

LGTM w/ very minor nits.  Thanks for doing this!  I'm sure others will find it
helpful.

After committing, please work with someone who has chromite (browser) commit
access to get these changes into depot_tools as well.

-Doug

[diandersAtChromium, 2011-02-01 23:08:16]

http://codereview.chromium.org/6312068/diff/2001/bin/chromite
File bin/chromite (right):

http://codereview.chromium.org/6312068/diff/2001/bin/chromite#newcode30
bin/chromite:30: def ReportChromiteError(message):
nit: Should probably start w/ _, since this is private.

http://codereview.chromium.org/6312068/diff/2001/bin/chromite#newcode38
bin/chromite:38: def TryChromiteShell(dir_, argv):
nit: Also start w/ underscore.

[diandersAtChromium, 2011-02-02 23:15:28]

I like changes to avoid the exec(), but please address comments and re-upload.

Thanks!

http://codereview.chromium.org/6312068/diff/5001/bin/chromite
File bin/chromite (right):

http://codereview.chromium.org/6312068/diff/5001/bin/chromite#newcode30
bin/chromite:30: def ReportChromiteError(message):
nit: Should probably start w/ _, since this is private.  Should also have
docstring.

http://codereview.chromium.org/6312068/diff/5001/bin/chromite#newcode38
bin/chromite:38: def TryChromiteShell(dir_):
nit: Should probably start w/ _, since this is private.  Should also have
docstring.

http://codereview.chromium.org/6312068/diff/5001/bin/chromite#newcode48
bin/chromite:48: sys.path.insert(1, None)
A few issues here:

1. We don't need to insert anything into sys.path if we're inside the chroot. 
Don't insert anything in that case.

2. This line needs some comments, since it's not obvious.  Why inserting None? 
Why inserting at position 1 (as opposed to position 0)?

http://codereview.chromium.org/6312068/diff/5001/bin/chromite#newcode78
bin/chromite:78: main_function()
Please indent by 2 spaces so this is in the __name__ == '__main__' case.

http://codereview.chromium.org/6312068/diff/5001/bin/chromite#newcode79
bin/chromite:79: sys.exit(0)
Why is sys.exit needed?

[diandersAtChromium, 2011-02-02 23:39:26]

Ah, hadn't realized that kwaters had incorporated your changes into his script
too.  We should figure out which of the two CLs we want.  
  http://codereview.chromium.org/6334039

[diandersAtChromium, 2011-02-03 00:45:15]

Closing, since http://codereview.chromium.org/6334039/ is the CL we're going to
push eventually.