Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Side by Side Diff: chrome/browser/password_manager/password_store_win_unittest.cc

Issue 6312029: Disable PasswordStoreWinTest.ConvertIE7Login, hangs flakily... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <windows.h> 5 #include <windows.h>
6 #include <wincrypt.h> 6 #include <wincrypt.h>
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/message_loop.h" 10 #include "base/message_loop.h"
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 ACTION(QuitUIMessageLoop) { 137 ACTION(QuitUIMessageLoop) {
138 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 138 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
139 MessageLoop::current()->Quit(); 139 MessageLoop::current()->Quit();
140 } 140 }
141 141
142 MATCHER(EmptyWDResult, "") { 142 MATCHER(EmptyWDResult, "") {
143 return static_cast<const WDResult<std::vector<PasswordForm*> >*>( 143 return static_cast<const WDResult<std::vector<PasswordForm*> >*>(
144 arg)->GetValue().empty(); 144 arg)->GetValue().empty();
145 } 145 }
146 146
147 TEST_F(PasswordStoreWinTest, ConvertIE7Login) { 147 // Hangs flakily, http://crbug.com/71385.
148 TEST_F(PasswordStoreWinTest, DISABLED_ConvertIE7Login) {
148 IE7PasswordInfo password_info; 149 IE7PasswordInfo password_info;
149 ASSERT_TRUE(CreateIE7PasswordInfo(L"http://example.com/origin", 150 ASSERT_TRUE(CreateIE7PasswordInfo(L"http://example.com/origin",
150 base::Time::FromDoubleT(1), 151 base::Time::FromDoubleT(1),
151 &password_info)); 152 &password_info));
152 // Verify the URL hash 153 // Verify the URL hash
153 ASSERT_EQ(L"39471418FF5453FEEB3731E382DEB5D53E14FAF9B5", 154 ASSERT_EQ(L"39471418FF5453FEEB3731E382DEB5D53E14FAF9B5",
154 password_info.url_hash); 155 password_info.url_hash);
155 156
156 // This IE7 password will be retrieved by the GetLogins call. 157 // This IE7 password will be retrieved by the GetLogins call.
157 wds_->AddIE7Login(password_info); 158 wds_->AddIE7Login(password_info);
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
495 BrowserThread::PostTask(BrowserThread::DB, FROM_HERE, 496 BrowserThread::PostTask(BrowserThread::DB, FROM_HERE,
496 new SignalingTask(&done)); 497 new SignalingTask(&done));
497 done.Wait(); 498 done.Wait();
498 499
499 // Handle the callback from the WDS. 500 // Handle the callback from the WDS.
500 MessageLoop::current()->RunAllPending(); 501 MessageLoop::current()->RunAllPending();
501 502
502 STLDeleteElements(&expected_autofillable); 503 STLDeleteElements(&expected_autofillable);
503 STLDeleteElements(&expected_blacklisted); 504 STLDeleteElements(&expected_blacklisted);
504 } 505 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698