Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 6312013: Add one more Valgrind header (memcheck.h) and update the one we already have.... (Closed)

Created:
9 years, 11 months ago by Alexander Potapenko
Modified:
9 years, 6 months ago
CC:
chromium-reviews, stuartmorgan+watch_chromium.org, Alexander Potapenko, brettw-cc_chromium.org, eugenis
Visibility:
Public.

Description

Add one more Valgrind header (memcheck.h) and update the one we already have. This patch was prepared by eugenis@chromium.org (doesn't have a committer access yet) and reviewed at http://codereview.chromium.org/6327018/ TBR=evanm,timurrrr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72632

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1266 lines, -120 lines) Patch
M base/third_party/valgrind/README.chromium View 1 chunk +6 lines, -7 lines 0 comments Download
A base/third_party/valgrind/memcheck.h View 1 chunk +279 lines, -0 lines 0 comments Download
M base/third_party/valgrind/valgrind.h View 58 chunks +981 lines, -113 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Alexander Potapenko
9 years, 11 months ago (2011-01-26 12:06:00 UTC) #1
Timur Iskhodzhanov
9 years, 11 months ago (2011-01-26 13:40:39 UTC) #2
LGTM indeed

Powered by Google App Engine
This is Rietveld 408576698