Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1230)

Unified Diff: chrome/browser/multi_process_notification_win.cc

Issue 6312007: Fix up notifications so that they aren't only on Browser IOThread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added name and domain accessors to Listener interface Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/multi_process_notification_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/multi_process_notification_win.cc
diff --git a/chrome/browser/multi_process_notification_win.cc b/chrome/browser/multi_process_notification_win.cc
index 6d1fb12db652d861aeab873f4b7efe2a6e98f241..940556f4cbd34996a32af2f1587a1fef1dbbcdc3 100644
--- a/chrome/browser/multi_process_notification_win.cc
+++ b/chrome/browser/multi_process_notification_win.cc
@@ -20,7 +20,10 @@ class ListenerImpl {
Domain domain,
Listener::Delegate* delegate);
- bool Start();
+ bool Start(MessageLoop* io_loop_to_listen_on);
+
+ std::string name() const { return name_; }
+ Domain domain() const { return domain_; }
private:
std::string name_;
@@ -36,7 +39,7 @@ ListenerImpl::ListenerImpl(const std::string& name,
: name_(name), domain_(domain), delegate_(delegate) {
}
-bool ListenerImpl::Start() {
+bool ListenerImpl::Start(MessageLoop* io_loop_to_listen_on) {
// TODO(dmaclach): Implement
NOTIMPLEMENTED();
return false;
@@ -51,8 +54,16 @@ Listener::Listener(const std::string& name,
Listener::~Listener() {
}
-bool Listener::Start() {
- return impl_->Start();
+bool Listener::Start(MessageLoop* io_loop_to_listen_on) {
+ return impl_->Start(io_loop_to_listen_on);
+}
+
+std::string Listener::name() const {
+ return impl_->name();
+}
+
+Domain Listener::domain() const {
+ return impl_->domain();
}
} // namespace multi_process_notification
« no previous file with comments | « chrome/browser/multi_process_notification_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698