Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3436)

Unified Diff: chrome/browser/multi_process_notification.h

Issue 6312007: Fix up notifications so that they aren't only on Browser IOThread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added name and domain accessors to Listener interface Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/multi_process_notification_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/multi_process_notification.h
diff --git a/chrome/browser/multi_process_notification.h b/chrome/browser/multi_process_notification.h
index 5e15801320d6454b8e5691c8eec6f3063fa3b55a..6aa2fc62f38d870762fdf16741584e92a0b54ce7 100644
--- a/chrome/browser/multi_process_notification.h
+++ b/chrome/browser/multi_process_notification.h
@@ -10,6 +10,7 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
+#include "base/message_loop.h"
#include "base/scoped_ptr.h"
#include "base/task.h"
@@ -95,8 +96,15 @@ class Listener {
~Listener();
// A listener is not considered valid until Start() returns true and its
- // delegate's OnListenerStarted method is called with |success| == true
- bool Start();
+ // delegate's OnListenerStarted method is called with |success| == true.
+ // |io_loop_to_listen_on| is the message loop to register the listener on.
+ // All callbacks will be made in the same thread that "Start" is called on,
+ // not the thread that owns io_loop_to_listen_on.
+ // |io_loop_to_listen_on| must be of type TYPE_IO.
+ bool Start(MessageLoop* io_loop_to_listen_on);
+
+ std::string name() const;
+ Domain domain() const;
private:
scoped_ptr<ListenerImpl> impl_;
« no previous file with comments | « no previous file | chrome/browser/multi_process_notification_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698