Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 6312007: Fix up notifications so that they aren't only on Browser IOThread. (Closed)

Created:
9 years, 11 months ago by dmac
Modified:
9 years, 7 months ago
Reviewers:
awong, garykac
CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix up notifications so that they aren't only on Browser IOThread. I wasn't thinking and realized I need to get rid of the dependency on Browser IOThread, because the service process doesn't have one. This means I can move this back to chrome/common, but I won't do that until you have finished your implementations. BUG=NONE TEST=BUILD Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71961

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixed up with garykac comments #

Patch Set 3 : Added name and domain accessors to Listener interface #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -49 lines) Patch
M chrome/browser/multi_process_notification.h View 1 2 2 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/multi_process_notification_linux.cc View 1 2 3 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/multi_process_notification_mac.mm View 1 2 8 chunks +26 lines, -10 lines 0 comments Download
M chrome/browser/multi_process_notification_unittest.cc View 1 2 9 chunks +31 lines, -29 lines 0 comments Download
M chrome/browser/multi_process_notification_win.cc View 1 2 3 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dmac
Would you gentlemen please take a look?
9 years, 11 months ago (2011-01-19 22:40:34 UTC) #1
dmac
http://codereview.chromium.org/6312007/diff/1/chrome/browser/multi_process_notification_mac.mm File chrome/browser/multi_process_notification_mac.mm (right): http://codereview.chromium.org/6312007/diff/1/chrome/browser/multi_process_notification_mac.mm#newcode436 chrome/browser/multi_process_notification_mac.mm:436: return false; On 2011/01/19 22:49:40, garykac wrote: > Log ...
9 years, 11 months ago (2011-01-19 23:14:41 UTC) #2
awong
LGTM
9 years, 11 months ago (2011-01-19 23:26:59 UTC) #3
dmac
Sorry guys... now that I'm using my class seeing some minor changes. Just added name ...
9 years, 11 months ago (2011-01-20 00:27:07 UTC) #4
garykac
9 years, 11 months ago (2011-01-20 01:10:50 UTC) #5
On 2011/01/20 00:27:07, dmac wrote:
> Sorry guys... now that I'm using my class seeing some minor changes. Just
added
> name and domain accessors to listeners. Mind taking one more look?

LGTM

Powered by Google App Engine
This is Rietveld 408576698