Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 6312006: Fix generating descriptions of policy template strings (Closed)

Created:
9 years, 11 months ago by gfeher
Modified:
9 years, 7 months ago
Reviewers:
Jói
CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr., Jakob Kummerow
Visibility:
Public.

Description

Fix generating descriptions of policy template strings BUG=none TEST=python:PolicyJsonUnittest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71808

Patch Set 1 #

Patch Set 2 : add test #

Patch Set 3 : fix typo #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M tools/grit/grit/gather/policy_json.py View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M tools/grit/grit/gather/policy_json_unittest.py View 1 2 3 4 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
gfeher
Please review this. I've found this problem while trying to push PolicyJson into internal grit.
9 years, 11 months ago (2011-01-19 11:04:52 UTC) #1
Jói
9 years, 11 months ago (2011-01-19 17:13:50 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698