Issue 6310015: [Sync] Roll cache-invalidation to @70

Issue 6310015: [Sync] Roll cache-invalidation to @70 (Closed)

Created:
9 years, 11 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
ghc, Nicolas Zea

CC:
chromium-reviews, Raghu Simha, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Sync] Roll cache-invalidation to @70 Pass user agent to InvalidationClientImpl as client_info. Pick up fix for bug that was causing increased server traffic. BUG=70674 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72468

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed ghc's comment #

Patch Set 3 : Fix compile failure #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -12 lines)			Patch
M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/notifier/chrome_invalidation_client.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/notifier/chrome_invalidation_client.cc	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/notifier/chrome_invalidation_client_unittest.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/sync/notifier/server_notifier_thread.cc	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/sync/tools/sync_listen_notifications.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ghc

LGTM http://codereview.chromium.org/6310015/diff/1/chrome/browser/sync/notifier/chrome_invalidation_client.cc File chrome/browser/sync/notifier/chrome_invalidation_client.cc (right): http://codereview.chromium.org/6310015/diff/1/chrome/browser/sync/notifier/chrome_invalidation_client.cc#newcode68 chrome/browser/sync/notifier/chrome_invalidation_client.cc:68: client_info, client_config, this)); client_info should fit on the ...

9 years, 11 months ago (2011-01-24 23:09:34 UTC) #2

akalin

9 years, 11 months ago (2011-01-24 23:17:17 UTC) #4

Checking in as soon as trybots pass

http://codereview.chromium.org/6310015/diff/1/chrome/browser/sync/notifier/ch...
File chrome/browser/sync/notifier/chrome_invalidation_client.cc (right):

http://codereview.chromium.org/6310015/diff/1/chrome/browser/sync/notifier/ch...
chrome/browser/sync/notifier/chrome_invalidation_client.cc:68: client_info,
client_config, this));
On 2011/01/24 23:09:34, ghc wrote:
> client_info should fit on the previous line, no?

Done.

Expand Messages | Collapse Messages